- 
                Notifications
    
You must be signed in to change notification settings  - Fork 2.7k
 
Improve OAuth protected resource metadata URL construction per RFC 9728 #1407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
            pcarleton
  merged 8 commits into
  modelcontextprotocol:main
from
shulkx:fix/well-known-oauth-path-mismatch
  
      
      
   
  Oct 6, 2025 
      
    
      
        
          +192
        
        
          −32
        
        
          
        
      
    
  
  
     Merged
                    Changes from 7 commits
      Commits
    
    
            Show all changes
          
          
            8 commits
          
        
        Select commit
          Hold shift + click to select a range
      
      2b85dbd
              
                refactor: improve OAuth protected resource metadata URL construction …
              
              
                shulkx 2023262
              
                refactor: reorganize imports and clean up whitespace in server.py
              
              
                shulkx d3f8564
              
                refactor: encapsulate resource metadata URL construction in a dedicat…
              
              
                shulkx 5780d4d
              
                test: enhance OAuth 2.0 Protected Resource tests for path-based resou…
              
              
                shulkx 4cfc056
              
                fix: append /mcp to resource_server_url with trailing slash handling
              
              
                shulkx d2d3c74
              
                test: add tests for resource metadata URL construction and route cons…
              
              
                shulkx 2bc3292
              
                fix: align token verifier audience with OAuth server response
              
              
                shulkx e4ba2ee
              
                refactor: consolidate /mcp path into server_url
              
              
                shulkx File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
There are no files selected for viewing
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
      
      Oops, something went wrong.
        
    
  
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be clearer to change the input server_url to be the correct one rather than tacking on
/mcpin both places here. The server URL makes more sense to be the URL for the MCP route.Here:
python-sdk/examples/servers/simple-auth/mcp_simple_auth/server.py
Line 35 in 2bc3292
and here:
python-sdk/examples/servers/simple-auth/mcp_simple_auth/server.py
Line 140 in 2bc3292
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed. Please check.