fix(client): gate completion/complete on the completions capability - #846
Merged
devcrocod merged 3 commits intoJun 29, 2026
Merged
Conversation
devcrocod
approved these changes
Jun 29, 2026
devcrocod
left a comment
devcrocod
left a comment
Contributor
There was a problem hiding this comment.
thanks for contributing!
lgtm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gate
completion/completeon the server'scompletionscapability instead ofprompts.closes #845
Motivation and Context
A server that declares
completionsbut notpromptsis currently rejected for completion. Details in #845.How Has This Been Tested?
New
ClientAssertCapabilityTestcases; they fail onmainand pass with this change.apiCheck/ktlintCheck/detektpass.Breaking Changes
None.
Types of changes
Checklist