refactor: Harden detekt setup, address some issues - #507
Merged
Conversation
13 tasks
kpavlov
force-pushed
the
kpavlov/harden-detekt
branch
from
February 6, 2026 13:58
9bf6c68 to
02cb573
Compare
e5l
previously approved these changes
Feb 11, 2026
e5l
left a comment
e5l
left a comment
Contributor
There was a problem hiding this comment.
Please add a GitHub Action to lint PRs before merging this one.
It would also be nice if we manage to autorun the formatter before commit or as an additional commit, I would log a task issue for that
skarpovdev
approved these changes
Feb 13, 2026
kpavlov
force-pushed
the
kpavlov/harden-detekt
branch
3 times, most recently
from
February 13, 2026 20:02
91dee96 to
da793ec
Compare
…ce Detekt setup - Address some detekt findings: missing KDocs, formatting, use `check*` & `orEmpty()`` - Remove unnecessary KDoc comments from deprecated classes in `types.kt` - Add Detekt baseline XML files for all modules - Enforce stricter Detekt rules by setting `failOnSeverity` to `Error` No breaking changes.
kpavlov
force-pushed
the
kpavlov/harden-detekt
branch
from
February 13, 2026 20:03
da793ec to
ac6b5d9
Compare
kpavlov
marked this pull request as ready for review
February 13, 2026 20:17
Contributor
Author
|
This pull request is aligned with the latest changes from the main branch. I’ll merge it promptly before it drifts out of sync again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Detekt setup hardeing; address some issues
check*& `orEmpty()``types.ktfailOnSeverityfromNonetoErrorMotivation and Context
Detekt is not actually failing the build on violations. This PR is enabling Detekt to fail on errors. Baseline fines added for historical issues. Follow-up for #501
How Has This Been Tested?
Regressions
Breaking Changes
No breaking changes.
Types of changes
Checklist