Properly check content type. Should fix #450 #451
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes issue #450 by correcting the content type validation in the SSE server transport. The change updates the equality check to use the proper content type matching method, which handles content type parameters correctly (such as charset specifications).
Key Changes:
- Updated content type validation to use
match()instead of direct equality comparison
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
kpavlov
approved these changes
Dec 5, 2025
devcrocod
approved these changes
Dec 5, 2025
kpavlov
force-pushed
the
n500/450-fix-content-type-check
branch
from
8e06fad to
52300c3
Compare
kpavlov
force-pushed
the
n500/450-fix-content-type-check
branch
from
52300c3 to
61fc03d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
#450
How Has This Been Tested?
Breaking Changes
Types of changes
Checklist
Additional context