Skip to content

Conversation

@tiginamaria
Copy link
Contributor

Motivation and Context

Make naming more clear to distinguish between server and mcp server
Add configurer to server to add resources during initialization

How Has This Been Tested?

Breaking Changes

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

@kpavlov kpavlov added the refactoring Making things better label Oct 31, 2025
kpavlov
kpavlov previously approved these changes Oct 31, 2025
Copy link
Contributor

@kpavlov kpavlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed together in a pair-programming session – looks good!

Copy link
Contributor

@devcrocod devcrocod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is quite a significant change, and I don’t fully understand the reason for the renaming

Make naming more clear to distinguish between server and mcp server

Which Server is being referred to here?
Isn’t the package-level distinction enough?

Also, by reserving the names McpClient and McpServer, we lose the ability to follow the same pattern as in the typescript and python sdks, where we have both Server / Client and the higher-level McpServer / McpClient

Fix ktlint for tests
@kpavlov kpavlov marked this pull request as draft November 3, 2025 18:28
@kpavlov
Copy link
Contributor

kpavlov commented Nov 3, 2025

See #364

@kpavlov kpavlov closed this Nov 3, 2025
@kpavlov kpavlov deleted the tigina/refactor-server branch November 3, 2025 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactoring Making things better

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants