Fix duplicate OAuth redirect URIs #862
Open
+8
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
InspectorOAuthClientProvider
has getters forredirectUrl
anddebugRedirectUrl
which contain distinctly different URLs.clientMetadata
getter returns an object withredirectUris
set to an array that contains references to both those getters. Seems fine execpt...DebugInspectorOAuthClientProvider
subclass has an overriddenredirectUrl
getter that returnsthis.debugRedirectUrl
.debugRedirectUrl
in an array, leading to an error "Duplicate redirectURIs" as reported in Duplicate redirect URIs generated by DebugInspectorOAuthClientProvider cause DCR failure #825redirect_uris
getter toInspectorOAuthClientProvider
which returns an array ofredirectUrl
anddebugRedirectUrl
but de-duped. So if you are using the subclass, you will only have thedebugRedirectUrl
in that array, otherwise both.How Has This Been Tested?
Against https://example-server.modelcontextprotocol.io/mcp using the OAuth debugger
Before
After
Breaking Changes
Nope.
Types of changes
Checklist
Additional context
Fixes #825