Auto log-level handling support #774
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- set TS SDK to 1.17.5, which has the automatic log level handling * In useConnection.ts - push the logging/setLevel message onto the message history stack so it is clear in the Inspector that it has been sent.
12 tasks
olaservo
approved these changes
Sep 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
logging/setLevelmessage onto the message history stack so it is clear in the Inspector that it has been sent.Motivation and Context
Previously, we were sending a
logging/setLevelmessage to any server that advertises support for logging, as per the spec. However, we were not showing that message in the message history. This PR's only functional change is to show that message.Also, the latest Typescript SDK has support for automatic handling of logging level. This PR bumps the TS SDK version to the latest version, even though it is a server side feature.
How Has This Been Tested?
Also, another PR is coming for the Servers repo, which bumps the SDK version and fixes a logging regression that was introduced in a previous PR.
Breaking Changes
Nope.
Types of changes
Checklist
Additional context