Skip to content

SDK v2 migration (behavior-neutral, versionNegotiation: 'legacy') (#1624) #1688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cliffhall merged 6 commits into from
Jul 16, 2026
Merged

SDK v2 migration (behavior-neutral, versionNegotiation: 'legacy') (#1624) #1688

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
19a6df7
SDK v2 migration (behavior-neutral, versionNegotiation: 'legacy') (#1…
cliffhall Jul 15, 2026
f9f79ff
Address @claude review: format core/, typed output-validation error, …
cliffhall Jul 15, 2026
8a7a38f
Fix MCP App load regression: translate ext-apps v1 setNotificationHan…
cliffhall Jul 15, 2026
39362dd
Merge remote-tracking branch 'origin/v2/main' into v2/sdk-v2-migratio…
cliffhall Jul 15, 2026
dbb8c40
Address review: justify/refine SDK-gap casts (`as unknown as`)
cliffhall Jul 15, 2026
f4fb4b5
Forward RFC 9207 `iss` to the v2 SDK (fixes OAuth + EMA leg 1)
cliffhall Jul 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions clients/cli/__tests__/error-handler.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,8 +193,8 @@ describe("classifyError", () => {
expect(envelope.status).toBe(403);
});

it("ignores a JSON-RPC McpError numeric .code (outside the HTTP range) as a status", () => {
// MCP SDK's McpError carries a numeric `.code` that is a JSON-RPC error
it("ignores a JSON-RPC ProtocolError numeric .code (outside the HTTP range) as a status", () => {
// MCP SDK's ProtocolError carries a numeric `.code` that is a JSON-RPC error
// code (e.g. -32601 MethodNotFound), NOT an HTTP status. It must not leak
// into `status`, nor get misclassified as AUTH_REQUIRED.
const err = Object.assign(new Error("Method not found"), { code: -32601 });
Expand Down
Loading
Loading