Skip to content

fix: export jsonResponse field #397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 3, 2025
Merged

fix: export jsonResponse field #397

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions mcp/streamable.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,8 @@ type StreamableHTTPOptions struct {

// TODO: support session retention (?)

// jsonResponse is forwarded to StreamableServerTransport.jsonResponse.
jsonResponse bool
// JSONResponse is forwarded to StreamableServerTransport.jsonResponse.
JSONResponse bool
}

// NewStreamableHTTPHandler returns a new [StreamableHTTPHandler].
Expand Down Expand Up @@ -233,7 +233,7 @@ func (h *StreamableHTTPHandler) ServeHTTP(w http.ResponseWriter, req *http.Reque
transport = &StreamableServerTransport{
SessionID: sessionID,
Stateless: h.opts.Stateless,
jsonResponse: h.opts.jsonResponse,
jsonResponse: h.opts.JSONResponse,
}

// To support stateless mode, we initialize the session with a default
Expand Down Expand Up @@ -487,7 +487,7 @@ type stream struct {
// jsonResponse records whether this stream should respond with application/json
// instead of text/event-stream.
//
// See [StreamableServerTransportOptions.jsonResponse].
// See [StreamableServerTransportOptions.JSONResponse].
jsonResponse bool

// signal is a 1-buffered channel, owned by an incoming HTTP request, that signals
Expand Down
2 changes: 1 addition & 1 deletion mcp/streamable_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ func TestStreamableTransports(t *testing.T) {
// Start an httptest.Server with the StreamableHTTPHandler, wrapped in a
// cookie-checking middleware.
handler := NewStreamableHTTPHandler(func(req *http.Request) *Server { return server }, &StreamableHTTPOptions{
jsonResponse: useJSON,
JSONResponse: useJSON,
})

var (
Expand Down