fix: complete #374
Merged
fix: complete #374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Huabing (Robin) Zhao <[email protected]>
Contributor
|
Can you add a test? Our tests should have caught this. |
Contributor
|
Also the commit message should be something like: |
jba
previously requested changes
Aug 28, 2025
Contributor
jba
left a comment
jba
left a comment
There was a problem hiding this comment.
See comments in Conversation.
Contributor
Author
@jba this is my first PR on MCP Go SDK - could you suggest where is the best place to add this test? |
Contributor
Author
Guess it should be added to mcp_test.go. |
Signed-off-by: Huabing (Robin) Zhao <[email protected]>
zhaohuabing
force-pushed
the
fix-complete
branch
from
f827c11 to
13257c4
Compare
Contributor
Author
Done. |
Contributor
|
Thank you for the fix! |
findleyr
approved these changes
Aug 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mcp: change return value of Server.complete to concrete type
This makes it consistent with other methods that implement RPCs.
Fixes #375
cc @findleyr