mcp/streamable: fixes broken response to DELETE on session close #372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Takeshi Yoneda <[email protected]>
mathetake
changed the title
findleyr
reviewed
Aug 27, 2025
Signed-off-by: Takeshi Yoneda <[email protected]>
Contributor
Author
|
@findleyr thanks for the comment. I addressed both comments. |
findleyr
approved these changes
Aug 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the accept header check for DELETE request on connection close. Previously, the accept content type was checked unconditionally regardless of whether it is DELETE or not in StreamableHTTPHandler.ServeHTTP.
As a result, previously, any DELETE request from client here on session close always resulted in
"Accept must contain both 'application/json' and 'text/event-stream'response with the status code 400 (invalid request) as opposed to expecting 204 (no content).