-
Notifications
You must be signed in to change notification settings - Fork 329
feat: modality negotiation for ui/message and ui/update-model-context #119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
idosal
wants to merge
10
commits into
main
Choose a base branch
from
fix/ui-message-content
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+492
−32
Open
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
ee557a4
fix: ui/message accepts message array
idosal 20ea4d9
Merge remote-tracking branch 'origin/main' into fix/ui-message-content
idosal b31250f
modality negotiation
idosal e74ba3b
husky
idosal 901f104
remove view-side validation
idosal 90e9c24
husky
idosal 34697f0
update lock
idosal 94c432b
chore: update package-lock.json to sync with dependencies
idosal 5bf54d2
merge from main
idosal 50cf05e
Merge branch 'main' into fix/ui-message-content
ochafik File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The specification should document what content types are supported in the
contentarray. While the PR description mentions supporting images (e.g., "prompting the agent with a text message and an image"), the spec only shows a single text content block.Consider adding:
ContentBlocktype definitionThis would help implementers understand the full capabilities of this API and align with the stated goal of supporting additional use cases like multi-modal messages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ochafik I see that the SDK supports
ContentBlockas-is. There are types that are extremely cool and open up really interesting use cases, but I'm not sure hosts would know how to support and may require negotiation (e.g., audio, embedded resource). Should we limit it to text (and perhaps image if we add negotiation) for now?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@idosal let's just make it all negotiable:
cc/ @antonpk1 fyi
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@idosal what do you think about that one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ochafik sounds good. Let's merge this one and I'll open a new one for the negotiation