Skip to content

Avoid propagating server tool exception message to client #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 9, 2025
Merged

Avoid propagating server tool exception message to client #242

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1f126d9
Avoid propagating server tool exception message to client
stephentoub Apr 9, 2025
a9993b3
Merge branch 'main' into serverexception
eiriktsarpalis Apr 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/ModelContextProtocol/Server/AIFunctionMcpServerTool.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,7 @@ public override async Task<CallToolResponse> InvokeAsync(
return new CallToolResponse()
{
IsError = true,
Content = [new() { Text = e.Message, Type = "text" }],
Content = [new() { Text = $"An error occurred invoking '{request.Params?.Name}'.", Type = "text" }],
};
}

Expand Down
2 changes: 1 addition & 1 deletion tests/ModelContextProtocol.Tests/Configuration/McpServerBuilderExtensionsToolsTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -376,7 +376,7 @@ public async Task Returns_IsError_Content_When_Tool_Fails()
Assert.True(result.IsError);
Assert.NotNull(result.Content);
Assert.NotEmpty(result.Content);
Assert.Contains("Test error", result.Content[0].Text);
Assert.Contains("An error occurred", result.Content[0].Text);
}

[Fact]
Expand Down