Skip to content
Merged
Show file tree
Hide file tree
Changes from 6 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions examples/servers/typescript/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -170,3 +170,21 @@ If you're implementing MCP in another language/SDK:
5. **Handle Notifications Carefully**: Catch/ignore errors when no client is connected

**Goal**: All SDK example servers provide the same interface, enabling a single test suite to verify conformance across all implementations.

## Negative Test Cases

### no-dns-rebinding-protection.ts

A minimal MCP server that intentionally omits DNS rebinding protection. This is a **negative test case** that demonstrates what a vulnerable server looks like and is expected to **FAIL** the `dns-rebinding-protection` conformance scenario.

```bash
# Run the vulnerable server
npx tsx no-dns-rebinding-protection.ts

# This should FAIL the dns-rebinding-protection checks
npx @modelcontextprotocol/conformance server \
--url http://localhost:3003/mcp \
--scenario dns-rebinding-protection
```

**DO NOT** use this pattern in production servers. Always use `createMcpExpressApp()` or the `localhostHostValidation()` middleware for localhost servers.
6 changes: 3 additions & 3 deletions examples/servers/typescript/everything-server.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ import {
EventId,
StreamId
} from '@modelcontextprotocol/sdk/server/streamableHttp.js';
import { createMcpExpressApp } from '@modelcontextprotocol/sdk/server/express.js';

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: this example is going to get deleted in a follow-up PR to make the typescript-sdk example the source of truth. updating it in place for now.

import {
ElicitResultSchema,
ListToolsRequestSchema,
Expand All @@ -26,7 +27,6 @@ import {
} from '@modelcontextprotocol/sdk/types.js';
import { zodToJsonSchema } from 'zod-to-json-schema';
import { z } from 'zod';
import express from 'express';
import cors from 'cors';
import { randomUUID } from 'crypto';

Expand Down Expand Up @@ -1055,8 +1055,8 @@ function isInitializeRequest(body: any): boolean {

// ===== EXPRESS APP =====

const app = express();
app.use(express.json());
// Use createMcpExpressApp for DNS rebinding protection on localhost
const app = createMcpExpressApp();

// Configure CORS to expose Mcp-Session-Id header for browser-based clients
app.use(
Expand Down
64 changes: 64 additions & 0 deletions examples/servers/typescript/no-dns-rebinding-protection.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,64 @@
#!/usr/bin/env node

/**
* MCP Server WITHOUT DNS Rebinding Protection - Negative Test Case
*
* This is the simplest possible vulnerable server to demonstrate what happens
* when DNS rebinding protection is omitted. DO NOT use this pattern in production.
*
* This server should FAIL the dns-rebinding-protection conformance scenario.
*/

import { McpServer } from '@modelcontextprotocol/sdk/server/mcp.js';
import { StreamableHTTPServerTransport } from '@modelcontextprotocol/sdk/server/streamableHttp.js';
import express from 'express';

// Create minimal MCP server
const server = new McpServer({
name: 'no-dns-rebinding-protection-server',
version: '1.0.0'
});

// Add a simple tool
server.tool(
'echo',
'Echo the input back',
{ message: { type: 'string' } },
async ({ message }) => ({
content: [{ type: 'text', text: `Echo: ${message}` }]
})
);

// === VULNERABLE EXPRESS APP ===
// This intentionally does NOT use createMcpExpressApp() or localhostHostValidation()
const app = express();
app.use(express.json());
// NO DNS rebinding protection middleware here!

app.post('/mcp', async (req, res) => {
try {
// Stateless: no session ID
const transport = new StreamableHTTPServerTransport({
sessionIdGenerator: undefined
});
await server.connect(transport);
await transport.handleRequest(req, res, req.body);
} catch (error) {
if (!res.headersSent) {
res.status(500).json({
jsonrpc: '2.0',
error: {
code: -32603,
message: `Internal error: ${error instanceof Error ? error.message : String(error)}`
},
id: null
});
}
}
});

const PORT = parseInt(process.env.PORT || '3003', 10);
app.listen(PORT, '127.0.0.1', () => {
console.log(`Vulnerable server running on http://localhost:${PORT}/mcp`);
console.log(`WARNING: No DNS rebinding protection enabled!`);
});
10 changes: 10 additions & 0 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@
"eventsource-parser": "^3.0.6",
"express": "^5.1.0",
"jose": "^6.1.2",
"undici": "^7.19.0",
"yaml": "^2.8.2",
"zod": "^3.25.76"
}
Expand Down
7 changes: 6 additions & 1 deletion src/scenarios/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,8 @@ import {
PromptsGetWithImageScenario
} from './server/prompts';

import { DNSRebindingProtectionScenario } from './server/dns-rebinding';

import { authScenariosList } from './client/auth/index';
import { listMetadataScenarios } from './client/auth/discovery-metadata';

Expand Down Expand Up @@ -123,7 +125,10 @@ const allClientScenariosList: ClientScenario[] = [
new PromptsGetSimpleScenario(),
new PromptsGetWithArgsScenario(),
new PromptsGetEmbeddedResourceScenario(),
new PromptsGetWithImageScenario()
new PromptsGetWithImageScenario(),

// Security scenarios
new DNSRebindingProtectionScenario()
];

// Active client scenarios (excludes pending)
Expand Down
219 changes: 219 additions & 0 deletions src/scenarios/server/dns-rebinding.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,219 @@
/**
* DNS Rebinding Protection test scenarios for MCP servers
*
* Tests that localhost MCP servers properly validate Host headers to prevent
* DNS rebinding attacks. See GHSA-w48q-cv73-mx4w for details on the attack.
*/

import { ClientScenario, ConformanceCheck } from '../../types';
import { request } from 'undici';

const SPEC_REFERENCE = {
id: 'MCP-DNS-Rebinding-Protection',
url: 'https://modelcontextprotocol.io/specification/2025-11-25/basic/security_best_practices#local-mcp-server-compromise'
};

/**
* Check if URL is a localhost URL
*/
function isLocalhostUrl(serverUrl: string): boolean {
const url = new URL(serverUrl);
const hostname = url.hostname.toLowerCase();
return (
hostname === 'localhost' ||
hostname === '127.0.0.1' ||
Comment thread
maxisbey marked this conversation as resolved.
hostname === '[::1]' ||
hostname === '::1'
);
}

/**
* Get the host header value from a URL (hostname:port)
*/
function getHostFromUrl(serverUrl: string): string {
const url = new URL(serverUrl);
return url.host; // includes port if present
}

/**
* Send an MCP initialize request with a custom Host header
*/
async function sendRequestWithHost(
serverUrl: string,
hostHeader: string
): Promise<{ statusCode: number; body: unknown }> {
const response = await request(serverUrl, {
method: 'POST',
headers: {
'Content-Type': 'application/json',
Host: hostHeader,
Accept: 'application/json, text/event-stream'
},
body: JSON.stringify({
jsonrpc: '2.0',
id: 1,
method: 'initialize',
params: {
protocolVersion: '2024-11-05',
Comment thread
pcarleton marked this conversation as resolved.
Outdated
capabilities: {},
clientInfo: { name: 'conformance-dns-rebinding-test', version: '1.0.0' }
}
})
});

let body: unknown;
try {
body = await response.body.json();
} catch {
body = null;
}

return {
statusCode: response.statusCode,
body
};
}

export class DNSRebindingProtectionScenario implements ClientScenario {
name = 'dns-rebinding-protection';
description = `Test DNS rebinding protection for localhost servers.

**Scope:** This test applies to localhost MCP servers running without HTTPS and without
authentication. These servers are vulnerable to DNS rebinding attacks where a malicious
website tricks a user's browser into making requests to the local server.

**Attack scenario:**
1. User visits malicious website (e.g., evil.com)
2. evil.com's DNS is configured to resolve to 127.0.0.1
3. Browser makes request to evil.com which actually goes to localhost
4. Without Host header validation, the local MCP server processes the request

**Requirements:**
- Server **MUST** validate the Host header on incoming requests
- Server **MUST** reject requests with non-localhost Host headers (HTTP 4xx)
- Server **MUST** accept requests with valid localhost Host headers

**Valid localhost hosts:** \`localhost\`, \`127.0.0.1\`, \`[::1]\` (with optional port)

**Note:** This test requires a localhost server URL. Non-localhost URLs will fail.

See: https://github.com/modelcontextprotocol/typescript-sdk/security/advisories/GHSA-w48q-cv73-mx4w`;

async run(serverUrl: string): Promise<ConformanceCheck[]> {
const checks: ConformanceCheck[] = [];
const timestamp = new Date().toISOString();

// Common check properties
const rejectedCheckBase = {
id: 'localhost-host-rebinding-rejected',
name: 'DNSRebindingRejected',
description: 'Server rejects requests with non-localhost Host headers',
timestamp,
specReferences: [SPEC_REFERENCE]
};

const acceptedCheckBase = {
id: 'localhost-host-valid-accepted',
name: 'LocalhostHostAccepted',
description: 'Server accepts requests with valid localhost Host headers',
timestamp,
specReferences: [SPEC_REFERENCE]
};

// First check: Is this a localhost URL?
if (!isLocalhostUrl(serverUrl)) {
const errorMessage =
'DNS rebinding tests require a localhost server URL (localhost, 127.0.0.1, or [::1])';
const details = { serverUrl, reason: 'non-localhost-url' };

checks.push({
Comment thread
pcarleton marked this conversation as resolved.
...rejectedCheckBase,
status: 'FAILURE' as const,
Comment thread
pcarleton marked this conversation as resolved.
Outdated
errorMessage,
details
});
checks.push({
...acceptedCheckBase,
status: 'FAILURE' as const,
Comment thread
pcarleton marked this conversation as resolved.
Outdated
errorMessage,
details
});
return checks;
}

const validHost = getHostFromUrl(serverUrl);
const attackerHost = 'evil.example.com';

// Check 1: Invalid Host header should be rejected with a 4xx error
try {
const response = await sendRequestWithHost(serverUrl, attackerHost);
const isRejected =
response.statusCode >= 400 && response.statusCode < 500;
Comment thread
pcarleton marked this conversation as resolved.

const details = {
hostHeader: attackerHost,
statusCode: response.statusCode,
body: response.body
};

if (isRejected) {
checks.push({
...rejectedCheckBase,
status: 'SUCCESS' as const,
details
});
} else {
checks.push({
...rejectedCheckBase,
status: 'FAILURE' as const,
errorMessage: `Expected HTTP 4xx for invalid Host header, got ${response.statusCode}`,
details
});
}
} catch (error) {
checks.push({
...rejectedCheckBase,
status: 'FAILURE' as const,
errorMessage: `Request failed: ${error instanceof Error ? error.message : String(error)}`,
details: { hostHeader: attackerHost }
});
}

// Check 2: Valid localhost Host header should be accepted (2xx response)
try {
const response = await sendRequestWithHost(serverUrl, validHost);
const isAccepted =
response.statusCode >= 200 && response.statusCode < 300;

const details = {
hostHeader: validHost,
statusCode: response.statusCode,
body: response.body
};

if (isAccepted) {
checks.push({
...acceptedCheckBase,
status: 'SUCCESS' as const,
details
});
} else {
checks.push({
...acceptedCheckBase,
status: 'FAILURE' as const,
errorMessage: `Expected HTTP 2xx for valid localhost Host header, got ${response.statusCode}`,
details
});
}
} catch (error) {
checks.push({
...acceptedCheckBase,
status: 'FAILURE' as const,
errorMessage: `Request failed: ${error instanceof Error ? error.message : String(error)}`,
details: { hostHeader: validHost }
});
}

return checks;
}
}
Loading