Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Challenge 15 - High-Assurance SIMD Intrinsics for Rust #174

Merged
merged 11 commits into from
Jan 23, 2025

Conversation

karthikbhargavan
Copy link

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

@rahulku
Copy link

rahulku commented Nov 20, 2024

@tautschnig

Copy link
Member

@tautschnig tautschnig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am quite confused as to whether this is a challenge or a tool proposal.

doc/src/challenges/0014-intrinsics-simd.md Outdated Show resolved Hide resolved
doc/src/challenges/0014-intrinsics-simd.md Outdated Show resolved Hide resolved
doc/src/challenges/0014-intrinsics-simd.md Outdated Show resolved Hide resolved
doc/src/challenges/0014-intrinsics-simd.md Outdated Show resolved Hide resolved
Copy link
Member

@tautschnig tautschnig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let’s please disentangle producing the specifications from any particular tool. See detailed comments.

doc/src/challenges/0014-intrinsics-simd.md Outdated Show resolved Hide resolved
doc/src/challenges/0014-intrinsics-simd.md Outdated Show resolved Hide resolved
doc/src/challenges/0014-intrinsics-simd.md Outdated Show resolved Hide resolved
doc/src/challenges/0014-intrinsics-simd.md Outdated Show resolved Hide resolved
doc/src/challenges/0014-intrinsics-simd.md Outdated Show resolved Hide resolved
doc/src/challenges/0014-intrinsics-simd.md Outdated Show resolved Hide resolved
doc/src/challenges/0014-intrinsics-simd.md Outdated Show resolved Hide resolved
doc/src/challenges/0014-intrinsics-simd.md Outdated Show resolved Hide resolved
doc/src/challenges/0014-intrinsics-simd.md Outdated Show resolved Hide resolved
@tautschnig tautschnig self-assigned this Nov 27, 2024
Copy link

@feliperodri feliperodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After a first pass, my major comment is just to add more clarification on how to pick verification targets, avoid targeting tools to solve the challenge and do not attach the success criteria to any third-party libraries.

We can later send a tool proposal to be integrated into the repository and you can add more discussions on how to solve the challenge, even mentioning specific tools, in the GitHub issue corresponding to the challenge. However, this description should focus on what targets and properties are relevant and why.

  • note: I do encourage to use the application of this work in crypto to help prioritize the verification targets.

doc/src/challenges/0014-intrinsics-simd.md Outdated Show resolved Hide resolved
doc/src/challenges/0014-intrinsics-simd.md Outdated Show resolved Hide resolved
doc/src/challenges/0014-intrinsics-simd.md Outdated Show resolved Hide resolved
doc/src/challenges/0014-intrinsics-simd.md Outdated Show resolved Hide resolved
doc/src/challenges/0014-intrinsics-simd.md Outdated Show resolved Hide resolved
doc/src/challenges/0014-intrinsics-simd.md Outdated Show resolved Hide resolved
doc/src/challenges/0014-intrinsics-simd.md Outdated Show resolved Hide resolved
doc/src/challenges/0014-intrinsics-simd.md Outdated Show resolved Hide resolved
doc/src/challenges/0014-intrinsics-simd.md Outdated Show resolved Hide resolved
doc/src/challenges/0014-intrinsics-simd.md Outdated Show resolved Hide resolved
doc/src/challenges/0014-intrinsics-simd.md Outdated Show resolved Hide resolved
doc/src/challenges/0014-intrinsics-simd.md Outdated Show resolved Hide resolved
doc/src/challenges/0014-intrinsics-simd.md Outdated Show resolved Hide resolved
Copy link
Member

@tautschnig tautschnig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for removing all the (possible) implementation details!

doc/src/SUMMARY.md Outdated Show resolved Hide resolved
doc/src/challenges/0014-intrinsics-simd.md Outdated Show resolved Hide resolved
doc/src/challenges/0014-intrinsics-simd.md Outdated Show resolved Hide resolved
@feliperodri feliperodri changed the title New Challenge 14 - High-Assurance SIMD Intrinsics for Rust New Challenge 15 - High-Assurance SIMD Intrinsics for Rust Jan 23, 2025
@feliperodri feliperodri added the Challenge Used to tag a challenge label Jan 23, 2025
@feliperodri feliperodri added this pull request to the merge queue Jan 23, 2025
Merged via the queue into model-checking:main with commit 3cc0686 Jan 23, 2025
14 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Challenge Used to tag a challenge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants