Skip to content

Overflow operators can also be used with vectors #4049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2025
Merged

Overflow operators can also be used with vectors #4049

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions cprover_bindings/src/goto_program/expr.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1017,11 +1017,12 @@ impl Expr {
IeeeFloatEqual | IeeeFloatNotequal => lhs.typ == rhs.typ && lhs.typ.is_floating_point(),
// Overflow flags
OverflowMinus | OverflowResultMinus => {
(lhs.typ == rhs.typ && (lhs.typ.is_pointer() || lhs.typ.is_numeric()))
(lhs.typ == rhs.typ
&& (lhs.typ.is_pointer() || lhs.typ.is_numeric() || lhs.typ.is_vector()))
|| (lhs.typ.is_pointer() && rhs.typ.is_integer())
}
OverflowMult | OverflowPlus | OverflowResultMult | OverflowResultPlus => {
(lhs.typ == rhs.typ && lhs.typ.is_integer())
(lhs.typ == rhs.typ && (lhs.typ.is_numeric() || lhs.typ.is_vector()))
|| (lhs.typ.is_pointer() && rhs.typ.is_integer())
}
ROk => lhs.typ.is_pointer() && rhs.typ.is_c_size_t(),
Expand Down
15 changes: 10 additions & 5 deletions tests/kani/SIMD/simd_float_ops_fixme.rs → tests/kani/SIMD/simd_float_ops.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,14 @@
// SPDX-License-Identifier: Apache-2.0 OR MIT

//! Ensure we can handle SIMD defined in the standard library
//! FIXME: <https://github.com/model-checking/kani/issues/2631>
#![allow(non_camel_case_types)]
#![feature(repr_simd, core_intrinsics, portable_simd)]
use std::intrinsics::simd::simd_add;
use std::simd::f32x4;

#[repr(simd)]
#[derive(Clone, PartialEq, kani::Arbitrary)]
pub struct f32x2(f32, f32);
pub struct f32x2([f32; 2]);

impl f32x2 {
fn as_array(&self) -> &[f32; 2] {
Expand All @@ -20,16 +19,22 @@ impl f32x2 {

#[kani::proof]
fn check_sum() {
let a = f32x2(0.0, 0.0);
let a = f32x2([0.0, 0.0]);
let b = kani::any::<f32x2>();
let sum = unsafe { simd_add(a.clone(), b) };
assert_eq!(sum.as_array(), a.as_array());
kani::assume(b.as_array()[0].is_normal());
kani::assume(b.as_array()[1].is_normal());
let sum = unsafe { simd_add(a.clone(), b.clone()) };
assert_eq!(sum.as_array(), b.as_array());
}

#[kani::proof]
fn check_sum_portable() {
let a = f32x4::splat(0.0);
let b = f32x4::from_array(kani::any());
kani::assume(b.as_array()[0].is_normal());
kani::assume(b.as_array()[1].is_normal());
kani::assume(b.as_array()[2].is_normal());
kani::assume(b.as_array()[3].is_normal());
// Cannot compare them directly: https://github.com/model-checking/kani/issues/2632
assert_eq!((a + b).as_array(), b.as_array());
}
Loading