fix: Allow multiple stub_verifieds on a single harness
#3805
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Oh, I wrote this PR in my mobile device without actual checks and it doesn't compiles 😅 I'll fix this few hours later |
ShoyuVanilla
force-pushed
the
issues-3804
branch
2 times, most recently
from
f3767c0 to
5c5d5f3
Compare
ShoyuVanilla
force-pushed
the
issues-3804
branch
from
5c5d5f3 to
85f9129
Compare
Contributor
Author
|
Closing this as we have #3808 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that we can actually use multple
stub_verifieds on a single harness internally, but the checking logic prevents such usages.This PR removes such restrection.
Resolves #3804
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.