Support fully-qualified --package arguments #3593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were previously matching the name of the package, which would limit users if the name is ambiguous. Instead, use `cargo pkgid` to validate the `--package` argument and to retrieve the package id.
Co-authored-by: Zyad Hassan <[email protected]>
|
Thanks @zhassan-aws! I love when you suggest changes... it makes my life much easier. 😃 |
celinval
commented
Oct 12, 2024
|
Thanks for fixing this! Any idea when this will be released on crates.io? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were previously matching the name of the package, which would limit users if the name is ambiguous.
Instead, use
cargo pkgidto validate the--packageargument and to retrieve the package id.Resolves #3563
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.