Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for f16 and f128 for toolchain upgrade to 6/28 #3306

Merged
merged 17 commits into from
Jul 1, 2024
Merged

Add support for f16 and f128 for toolchain upgrade to 6/28 #3306

merged 17 commits into from
Jul 1, 2024

Conversation

jaisnan
Copy link
Contributor

@jaisnan jaisnan commented Jun 28, 2024 •
edited
Loading

Adds support for f16 and f128, i.e

  1. adding translation to irep .
  2. generating arbitrary values for the new types
  3. generating basic invariants (checking if safe) for new types
  4. Adds sanity testing for arbitrary on the new types.

Resolves #3303

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

@jaisnan jaisnan requested a review from a team as a code owner June 28, 2024 16:22
@github-actions github-actions bot added the Z-BenchCI Tag a PR to run benchmark CI label Jun 28, 2024
zhassan-aws
zhassan-aws reviewed Jun 28, 2024
View reviewed changes
Copy link
Contributor

@zhassan-aws zhassan-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Should the title say "upgrade to 6/28" instead of 6/26?

tests/perf/s2n-quic Outdated Show resolved Hide resolved
cprover_bindings/src/goto_program/expr.rs Outdated Show resolved Hide resolved
cprover_bindings/src/goto_program/expr.rs Show resolved Hide resolved
cprover_bindings/src/goto_program/expr.rs Show resolved Hide resolved
cprover_bindings/src/irep/to_irep.rs Show resolved Hide resolved
cprover_bindings/src/irep/to_irep.rs Show resolved Hide resolved
cprover_bindings/src/irep/to_irep.rs Outdated Show resolved Hide resolved
cprover_bindings/src/irep/to_irep.rs Outdated Show resolved Hide resolved
tautschnig
tautschnig reviewed Jun 28, 2024
View reviewed changes
cprover_bindings/src/goto_program/mod.rs Outdated Show resolved Hide resolved
cprover_bindings/src/goto_program/typ.rs Outdated Show resolved Hide resolved
cprover_bindings/src/irep/to_irep.rs Outdated Show resolved Hide resolved
kani-compiler/src/kani_middle/attributes.rs Show resolved Hide resolved
@jaisnan jaisnan changed the title Add support for f16 and f128 for toolchain upgrade to 6/26 Add support for f16 and f128 for toolchain upgrade to 6/28 Jun 28, 2024
@jaisnan jaisnan requested a review from zhassan-aws June 28, 2024 18:09
zhassan-aws
zhassan-aws approved these changes Jun 28, 2024
View reviewed changes
cprover_bindings/src/irep/to_irep.rs Outdated Show resolved Hide resolved
celinval
celinval reviewed Jun 28, 2024
View reviewed changes
Copy link
Contributor

@celinval celinval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add some tests?

@zhassan-aws
Copy link
Contributor

Can you please add some tests?

I was going to mention this in my overall comment, but completely forgot 🙈

celinval
celinval previously requested changes Jun 28, 2024
View reviewed changes
Copy link
Contributor

@celinval celinval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you at least extend this test to include the new floating points?

https://github.com/model-checking/kani/blob/main/tests/kani/FloatingPoint/main.rs

This was referenced Jun 28, 2024
Open
Open
@jaisnan jaisnan requested a review from celinval June 28, 2024 22:06
@tautschnig tautschnig dismissed celinval’s stale review July 1, 2024 18:28

Review is stale as tests have been added.

@adpaco-aws adpaco-aws enabled auto-merge (squash) July 1, 2024 19:09
@adpaco-aws adpaco-aws merged commit d55f25b into model-checking:main Jul 1, 2024
24 of 25 checks passed
@jaisnan jaisnan deleted the toolchain-upgrade-3303 branch July 1, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tautschnig tautschnig tautschnig approved these changes

@adpaco-aws adpaco-aws adpaco-aws approved these changes

@zhassan-aws zhassan-aws zhassan-aws approved these changes

@celinval celinval Awaiting requested review from celinval

Assignees
No one assigned
Labels
Z-BenchCI Tag a PR to run benchmark CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Toolchain upgrade to nightly-2024-06-28 failed
5 participants
@jaisnan @zhassan-aws @tautschnig @celinval @adpaco-aws