Skip to content

Conversation

@tautschnig
Copy link
Member

Description of changes:

Source changes required by the following upstream commits:

Resolved issues:

Fixes: #2767

Related RFC:

n/a

Call-outs:

n/a

Testing:

  • How is this change tested? CI

  • Is this a refactor change? No

Checklist

  • Each commit message has a non-empty body, explaining why the change was made
  • n/a Methods or procedures are documented
  • Regression or unit tests are included, or existing tests cover the modified code
  • My PR is restricted to a single feature or bugfix

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

Source changes required by the following upstream commits:

* rust-lang/rust@2eca717a24 Remove EarlyErrorHandler argument from after_analysis callback
* rust-lang/rust@551f481ffb use AllocId instead of Allocation in ConstValue::ByRef
* rust-lang/rust@0f8908da27 cleanup op_to_const a bit; rename ConstValue::ByRef → Indirect

Fixes: model-checking#2767
@tautschnig tautschnig requested a review from a team as a code owner September 15, 2023 07:20
@tautschnig tautschnig added the Z-EndToEndBenchCI Tag a PR to run benchmark CI label Sep 15, 2023
@tautschnig tautschnig added Z-EndToEndBenchCI Tag a PR to run benchmark CI and removed Z-EndToEndBenchCI Tag a PR to run benchmark CI labels Sep 15, 2023
Copy link
Contributor

@zhassan-aws zhassan-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. The failures in the performance regressions are due to the usual fluctuations.

@zhassan-aws zhassan-aws added Z-EndToEndBenchCI Tag a PR to run benchmark CI and removed Z-EndToEndBenchCI Tag a PR to run benchmark CI labels Sep 15, 2023
@tautschnig tautschnig merged commit c3ff9ea into model-checking:main Sep 15, 2023
@tautschnig tautschnig deleted the toolchain-2023-09-15-manual branch September 15, 2023 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Z-EndToEndBenchCI Tag a PR to run benchmark CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Toolchain upgrade to nightly-2023-09-12 failed

2 participants