Fix codegen_rvalue_aggregate for tuples #2371
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
We need to use the operands in the order prescribed by the layout, and cannot blindly trust the order provided as input in the Rvalue.
Resolved issues:
n/a
Related RFC:
n/a
Call-outs:
n/a
Testing:
How is this change tested? The actual use of multi-element tuples might only be seen with future toolchains (cf. Upgrade toolchain to 2023-02-05 #2347).
Is this a refactor change? No.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.