Build in Ubuntu 18.04 container in 20.04 image #2311
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karkhaz
force-pushed
the
kk-1804-container
branch
10 times, most recently
from
23d3b19 to
d0f979c
Compare
Member
|
Is it actually a good idea to continue doing this? 18.04 is not going to see security updates either. |
karkhaz
force-pushed
the
kk-1804-container
branch
19 times, most recently
from
76d8c0c to
fe6070b
Compare
karkhaz
force-pushed
the
kk-1804-container
branch
from
0192688 to
3954e3f
Compare
Contributor
|
Can we stop supporting Ubuntu 18.04 instead? |
karkhaz
force-pushed
the
kk-1804-container
branch
from
3954e3f to
da464f2
Compare
Contributor
Author
|
@tautschnig @celinval building on 18.04 is still required for some use cases. There is also the fairly urgent issue of Diffblue no longer shipping 18.04 binaries, which this PR also seeks to address. |
karkhaz
force-pushed
the
kk-1804-container
branch
5 times, most recently
from
1026f48 to
3815d8f
Compare
zhassan-aws
reviewed
Mar 31, 2023
karkhaz
force-pushed
the
kk-1804-container
branch
from
3815d8f to
ad7975b
Compare
zhassan-aws
approved these changes
Mar 31, 2023
Contributor
zhassan-aws
left a comment
zhassan-aws
left a comment
There was a problem hiding this comment.
A couple of minor comments. Thanks for taking care of this @karkhaz!
karkhaz
force-pushed
the
kk-1804-container
branch
2 times, most recently
from
eb0e93a to
148c9ae
Compare
zhassan-aws
approved these changes
Apr 1, 2023
This is due to GitHub deprecating the Ubuntu 18.04 image. This commit fixes model-checking#1667.
karkhaz
force-pushed
the
kk-1804-container
branch
from
148c9ae to
8d7f501
Compare
4 tasks
celinval
added a commit
to celinval/kani-dev
that referenced
this pull request
Apr 6, 2023
Fix small issue introduced by model-checking#2311
celinval
added a commit
that referenced
this pull request
Apr 6, 2023
Fix small issue introduced by #2311
celinval
added a commit
to celinval/kani-dev
that referenced
this pull request
Apr 6, 2023
4 tasks
celinval
added a commit
that referenced
this pull request
Apr 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is due to GitHub deprecating the Ubuntu 18.04 image. This commit fixes #1667.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.