Build CBMC with cadical in nightly cbmc-latest workflow #2268
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Update nightly CBMC latest workflow to build CBMC with cadical. Without this, regressions that run cadical (e.g. https://github.com/model-checking/kani/blob/035225ca362b0a80c807af0f567c3513237cb0ee/tests/ui/solver-attribute/cadical/test.rs) fail.
Resolved issues:
Fixes nightly CBMC latest regressions.
Related RFC:
Optional #ISSUE-NUMBER.
Call-outs:
I couldn't get this to work through just adding
-Dsat_impl="minisat2;cadicalto this line:kani/.github/workflows/cbmc-latest.yml
Line 48 in 035225c
because the cadical configure step failed on macos-11. This needs investigation.
Testing:
How is this change tested? Regressions passed in my fork.
Is this a refactor change? No
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.