Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update toolchain to nightly-2022-07-19 #1399

Merged
merged 5 commits into from
Jul 22, 2022

Conversation

celinval
Copy link
Contributor

Description of changes:

This update required the following changes:

Resolved issues:

Resolves #1366

Call-outs:

Testing:

  • How is this change tested? New tests + old tests

  • Is this a refactor change? No

Checklist

  • Each commit message has a non-empty body, explaining why the change was made
  • Methods or procedures are documented
  • Regression or unit tests are included, or existing tests cover the modified code
  • My PR is restricted to a single feature or bugfix

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

This update required the following changes:
  - Add support to ProjectionElem::OpaqueCast
  - Add support to Rvalue::CopyForDeref
  - Add support to ConstValue::ZST
  - Rename debugging_opts to unstable_opts
  - Change to mem::uninit/zeroed validity checks
  - Change vecdeque harness due to std capacity check
@celinval celinval requested a review from a team as a code owner July 21, 2022 02:00
Copy link
Contributor

@zhassan-aws zhassan-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest adding a couple of references. Otherwise, looks good. Thanks!

assert_eq!(int.size(), Size::ZERO);
self.codegen_fndef(*d, substs, span)
(Scalar::Int(..), ty::FnDef(..)) => {
unreachable!("ZST is no longer represented as a scalar")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a comment that points to the rustc PR?

@@ -493,6 +494,9 @@ impl<'tcx> GotocCtx<'tcx> {
"https://github.com/model-checking/kani/issues/541",
)
}
Rvalue::CopyForDeref(place) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be helpful to refer to the comment in rustc that mentions that at the codegen level, this is just a read: https://github.com/rust-lang/rust/blob/1673f1450eeaf4a5452e086db0fe2ae274a0144f/compiler/rustc_middle/src/mir/syntax.rs#L1055

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update rust toolchain version for Kani 0.7
4 participants