Repository navigation
Conversation
jvmncs
force-pushed
the
codex/reconcile-sglang-v0.5.20-pin
branch
from
October 3, 2026 03:56
aaffa20 to
cc215d6
Compare
jvmncs
marked this pull request as draft
October 6, 2026 03:20
jvmncs
force-pushed
the
codex/reconcile-sglang-v0.5.20-pin
branch
from
October 7, 2026 01:33
cc215d6 to
2c319a4
Compare
jvmncs
force-pushed
the
codex/reconcile-sglang-v0.5.20-pin
branch
from
October 7, 2026 16:41
2c319a4 to
f5bf7ad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the cookbook serving runtime to SGLang v0.5.21 and pin the published fork. Keep the existing update flow: prepare inactive weights, pause generation, commit the weights, then resume generation.
The fork has 16 commits marked
[Weight Sync n/16]. Nan remains their author; Jason has co-author credit for the port. Tests are included with the implementation they cover. The retained upstream fixes preserve their author credit. The history repair produces exactly the same files and Git modes as measured revisionffbaf2cf907e.The implementation changes are:
weight_sync/files, 11 are unchanged from the published v0.5.20 branch.7686f6b711.Keep #34201, #32237, #35804, and #29916. Remove the separate patches already included in v0.5.21: #35204, #40075, #35798, #40932, #40986, #41235, and #40779. #41955 remains excluded. The v0.5.20 and staging branches are unchanged.
Confirmed by probes:
For large-model RAM updates, all 12 native-load comparisons passed. The first update measured:
Values are means ± 95% confidence half-widths from three distinct hosts per runtime and two runs per host. The old runtime varied widely across hosts. These runs do not reproduce the earlier preparation slowdown. Caches were uncontrolled; the results do not establish a general speedup or rule out other regressions.
The README contains the full phase and producer timing tables. Measurements used at most four GPUs per allocation. Large training and eight-GPU cases remain untested. Earlier sampling GPU coverage depends on inspection of later source changes. All validation apps are stopped.