Conversation
- generate_rollout compatibility wrapper and the unreachable per-request version-pinning branch (the live hook contract never supplies rollout_id); the request hook now does only what runs: retry budget + session affinity - test-only helpers: transition_artifact_paths, parse_extra_key_version, validate_policy (redundant with request_context) - register_routes extension point nothing passes - version error helpers inlined into evaluate_version_policy - unused top-level re-export facade in stitch/__init__.py
- unreachable per-request version-pin branch in the standalone slime hook (the hook contract never supplies rollout_id; announce_and_wait already gates staleness) + its helper, config knob, and tests - megatron_r3_num_out_tokens.patch: never applied, the fix is baked inline
- bulletin_hooks reads generic DELTA_APP_NAME / DELTA_SERVER_CLS_NAME env fallbacks; per-recipe hooks.py become pure re-export shims kept only because configs reference them by dotted string - per-recipe helpers.py shrink to the real per-recipe axes (sidecar module, model-script attr, wake mode) + one-line wrappers; miles-only materialize_node_local_yaml and start_host_mem_monitor move out of the shared trainer_helpers into miles_disagg/helpers - serving wrappers take the shared trainer_repo_* kwarg names; the shared builder computes the cookbook mount dir itself
…says Keep the behavioral fact, drop the provenance: external PR/issue labels (slime PR #5, radixark/miles#1261, P0.1), incident anecdotes, milestone roadmap prose (M1/M2/M3), and layout/design essays compressed to what the code needs the reader to know. Pinned SHAs stay; their changelog trailers go.
- root README: document all four cookbook recipes; fix the nonexistent slime extra claim - miles_disagg README: compress the fork changelog and bring-up checklist, fold the GLM-4.5-Air section into a variant note, point at the fork for the convert tools, document _spawn_into_deployed - standalone_rollouts README: compress the compatibility spec-dump and the SLIME-harness tail - slime_disagg README: merge the redundant Protocol notes into the run section - pyproject: drop uvicorn from the sglang extra (packaged code never imports it; Modal images install it explicitly)
jvmncs
added a commit
that referenced
this pull request
Jul 20, 2026
* Remove dead and speculative code from the core library - generate_rollout compatibility wrapper and the unreachable per-request version-pinning branch (the live hook contract never supplies rollout_id); the request hook now does only what runs: retry budget + session affinity - test-only helpers: transition_artifact_paths, parse_extra_key_version, validate_policy (redundant with request_context) - register_routes extension point nothing passes - version error helpers inlined into evaluate_version_policy - unused top-level re-export facade in stitch/__init__.py * Remove dangling cookbook artifacts - unreachable per-request version-pin branch in the standalone slime hook (the hook contract never supplies rollout_id; announce_and_wait already gates staleness) + its helper, config knob, and tests - megatron_r3_num_out_tokens.patch: never applied, the fix is baked inline * Dedup the slime/miles twin adapter modules - bulletin_hooks reads generic DELTA_APP_NAME / DELTA_SERVER_CLS_NAME env fallbacks; per-recipe hooks.py become pure re-export shims kept only because configs reference them by dotted string - per-recipe helpers.py shrink to the real per-recipe axes (sidecar module, model-script attr, wake mode) + one-line wrappers; miles-only materialize_node_local_yaml and start_host_mem_monitor move out of the shared trainer_helpers into miles_disagg/helpers - serving wrappers take the shared trainer_repo_* kwarg names; the shared builder computes the cookbook mount dir itself * De-noise prose: drop provenance labels, war stories, and docstring essays Keep the behavioral fact, drop the provenance: external PR/issue labels (slime PR #5, radixark/miles#1261, P0.1), incident anecdotes, milestone roadmap prose (M1/M2/M3), and layout/design essays compressed to what the code needs the reader to know. Pinned SHAs stay; their changelog trailers go. * Trim READMEs and packaging - root README: document all four cookbook recipes; fix the nonexistent slime extra claim - miles_disagg README: compress the fork changelog and bring-up checklist, fold the GLM-4.5-Air section into a variant note, point at the fork for the convert tools, document _spawn_into_deployed - standalone_rollouts README: compress the compatibility spec-dump and the SLIME-harness tail - slime_disagg README: merge the redundant Protocol notes into the run section - pyproject: drop uvicorn from the sglang extra (packaged code never imports it; Modal images install it explicitly)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.