Repository navigation
Bump DeepSeek-V4.1-Flash to miles dev-202610082133 image - #689
Closed
zhouhelena1 wants to merge 2 commits into
Closed
zhouhelena1 wants to merge 2 commits into
zhouhelena1 wants to merge 2 commits into
Conversation
Pins the standard multi-arch miles dev image (miles f5757caab with the radixark/miles#3605-#3634 kernel stack) and updates the shared zero-std and advantage-distribution patches for the moved/rewritten upstream sources. Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
|
Documentation preview: https://modal-labs-training-gym--training-gym-previews-preview-r-78da35.modal.run/689/docs |
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
This branch is waiting to be deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closing this bc current image already has DeepSeek-V4.1 DSA attention kernel, so we already see the benefits of radixark/miles#3608. This new image does fix a TileLang forward bug at 16 heads with top-k 128, but this doesn't match our recipe, so I'd prefer sticking to the default image than switching to dev image.
Moves
DeepSeek_V4_1_Flash_Recipe(8×8 H200) from the dedicateddsv41-h200-ea751aac8image to the standard multi-arch dev imageradixark/miles:dev-202610082133, pinned by digest. That image is milesf5757caab, which contains the radixark/miles#3605–#3634 kernel stack including #3608, with sglang-milesb84bec576and Megatron-LMfd15ee20a. Other Miles recipes are unchanged.Changes:
SGLANG_OPT_DEEPGEMM_HC_PRENORM=0to match upstream'srun_deepseek_v4_1.py, which turns off the compensated-MHC derived-weight cache that goes stale under online weight updates.deepseek_v41→deepseek_v4_1) were updated.patch_zero_std_metrics: now also matches the newuniform_rewardslayout from Fix uniform reward percentages for numeric rewards radixark/miles#3722. That upstream change still puts an int1and a float1.0in different buckets. Unit tests added.patch_advantage_distribution: findslog_utils.pyat its newtraining_utils/metrics/location (moved in training_utils: the shared layer for every training backend radixark/miles#3248). Before this fix it printed "not found" and was skipped.Validation
3-step run of
validate_model_configs.py check -m DeepSeek-V4.1-Flash -n 3inhelena-dev, compared with a run on the old image:messy-plate-d27a30d8cf5asophisticated-hoop-e728ce9825eaRollout traces for all 3 steps (128 samples each) look like the old image's. Responses are coherent and end with
\boxed{}answers, and the number truncated at 4096 tokens is about the same (66/105/69 vs 71/103/70). The new image reportsppo_klandpg_clipfracas exactly 0. With one optimizer step per rollout that means the training forward pass now reproduces thelog_probspass bit for bit, where the old image differed by about 1e-4.Wall time is roughly unchanged for this setup. In steps 2–3,
actor_trainis about 9% faster, which fits #3608's faster DSA attention. But optimizer step (about 4.5 min) dominates training time and the stack doesn't change it, whilelog_probsis somewhat slower. Pre-existing gaps that are the same on both images: dashboard stage labels for rollout substeps, andtrain_asyncsubstep timing.Locally: ruff, format, compileall, pre-commit, and the
tests/files pass. Two dashboard test files,test_dashboard_ingestion_auth.pyandtest_dashboard_metrics.py, hang locally; this PR doesn't touch them.Checklist
latestpython_versionfor the base image, if it is used~=x.y.zor==x.yversion < 1are pinned to patch version,==0.y.z