Skip to content

fix(weight-sync): load optional P2P dependencies lazily #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nanjiangwill wants to merge 1 commit into from
Closed

fix(weight-sync): load optional P2P dependencies lazily #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion miles/backends/megatron_utils/actor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,6 @@
from .replay_utils import register_replay_list_moe
from .update_weight.common import named_params_and_buffers
from .update_weight.update_weight_from_distributed.broadcast import UpdateWeightFromDistributed
from .update_weight.update_weight_from_distributed.p2p import UpdateWeightP2P
from .update_weight.update_weight_from_tensor import UpdateWeightFromTensor

if TYPE_CHECKING:
Expand Down Expand Up @@ -261,6 +260,10 @@ def init(

update_weight_cls = UpdateWeightFromDiskDelta
else:
# Mooncake loads its RDMA shared libraries at import time.
# Other transfer modes must not require a compatible RDMA setup.
from .update_weight.update_weight_from_distributed.p2p import UpdateWeightP2P

update_weight_cls = UpdateWeightP2P
self.weight_updater = update_weight_cls(
self.args,
Expand Down
Loading