modal shell takes container IDs now
#2336
Merged
+28
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thecodingwizard
approved these changes
Oct 14, 2024
mwaskom
reviewed
Oct 14, 2024
| @@ -331,49 +331,46 @@ def serve( | |||
|
|
|||
|
|
|||
| def shell( | |||
| func_ref: Optional[str] = typer.Argument( | |||
| container_or_function: Optional[str] = typer.Argument( | |||
There was a problem hiding this comment.
Nit, but one tricky thing about container_or_function is that they're not equivalent — the "container" mode is a container_id but while we do have a function_id concept, that isn't what you would pass here 🤔
There was a problem hiding this comment.
Yeah that makes sense! It's only internal though since the metavar in the help is REF so maybe fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Resolves MOD-4091, allowing you to do
modal shell ta-123456.Changelog
modal shellCLI command now takes a container ID, allowing you to shell into a running container.