fix: cannot import text_unidecode, nemo-toolkit #2068
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Currently when Task tracing was turned on for a customer's
modal.App
the Task failed on startup due to errors inimportlib
machinery which do not occur normally.The first issue was pypa/setuptools#4487. I could workaround that by doing
setuptools==70.3.0
but then I hit other issues. Those other issues are fixed by the changeset here.There's almost certainly more to understand about how an intercepting
Loader
should work but I think this change shouldn't introduce regressions.Check these boxes or delete any item (or this section) if not relevant for this PR.