Rails 5 support #6
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Locking the json to an old version seems uneccessary - Forcing multi_json and json_pure monkeypatching broke our test suite - removed the json_pure and so far so good
- in the specs it uses some json gem to render json which calls to_json on the object - in my app it uses an implementation that calls as_json on the object - to get the specs passing, to_json had to include quotes - to get my app to work as_json should not include quotes
|
@jamesdbloom i was able to get the tests passing! |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @jamesdbloom, this is cherry-picking the useful commits from mock-server/mockserver#288 to fix the version resolution for the activesuppport gem when using
mockserver-clientwith Rails 5It's older code, but we've tested and it's working for us with Ruby 2.5 and Rails 5.1. Would it be possible to get a new version release with these changes, if you approve? Thanks!