Skip to content

Un-ignore test.js #964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Un-ignore test.js #964

wants to merge 1 commit into from

Conversation

pwnall
Copy link
Contributor

@pwnall pwnall commented Aug 29, 2013

This seems to target lib/test.js, which is definitely necessary.
Not having it causes a require error in lib/interfaces/bdd.js

This seems to target lib/test.js, which is definitely necessary.
Not having it causes a require error in lib/interfaces/bdd.js
@tj
Copy link
Contributor

tj commented Aug 30, 2013

λ mocha (master): git ls-files | grep test.js
lib/test.js

@tj tj closed this Aug 30, 2013
@pwnall
Copy link
Contributor Author

pwnall commented Aug 30, 2013

The file is in the repository, and this setup worked well for me so far.

For some reason, this causes breakage on a co-worker's setup. OSX with node 0.10.17 and the bundled npm 1.3.8, installed from the .pkg on the site. (not via nvm or anything like that) I'm pointing to a git branch of mocha in "dependencies".

The npm docs claim that it uses .gitignore if no .npmignore exists. It seems like the fact that lib/test.js is packaged is a bug, and my co-worker stumbled upon a config where npm actually does what the docs claim it does. I thought it'd be a good idea to not rely on buggy behavior.
https://npmjs.org/doc/developers.html#Keeping-files-out-of-your-package

@tj
Copy link
Contributor

tj commented Aug 30, 2013

hmm lame, it should have been broken for a longggggg time then :s, mocha needs that file haha

@pwnall
Copy link
Contributor Author

pwnall commented Aug 30, 2013

Yeah, it didn't get broken on my setups. I'm not sure why it broke this one time, but it was a pretty vanilla setup. Want me to investigate further?

@tj
Copy link
Contributor

tj commented Aug 30, 2013

no big deal anymore since we're using .files in package.json it should be ok if it ever was messed up before

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants