Repository navigation
fix: preserve FIFO descriptors when respawning - #6254
Merged
mark-wiemer merged 1 commit intoAug 31, 2026
Merged
Conversation
Amp-Thread-ID: https://ampcode.com/threads/T-01a04e83-18e3-703b-9ff1-8a1b08a19772 Co-authored-by: Amp <amp@ampcode.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6254 +/- ##
==========================================
- Coverage 81.93% 81.81% -0.12%
==========================================
Files 64 64
Lines 4866 4873 +7
Branches 1100 1073 -27
==========================================
Hits 3987 3987
- Misses 879 886 +7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
|
Lgtm, good find, good fix |
mark-wiemer
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
status: accepting prsOverview
Applies a filter to
mochaArgs._to capture/dev/fd/*inputs. If one is found, we append its number and repam to/dev/fd/+ that number.I really, really didn't want to have to do things this way - it's super spooky to remap strings. But I couldn't figure out another approach. 🤷