Repository navigation
refactor!: replace yargs with Node.js util.parseArgs - #6164
Merged
Merged
Conversation
Co-authored-by: Amp <amp@ampcode.com> Amp-Thread-ID: https://ampcode.com/threads/T-019f1368-7b8d-775f-bf67-9d38a255d13f
Co-authored-by: Amp <amp@ampcode.com> Amp-Thread-ID: https://ampcode.com/threads/T-019f1368-7b8d-775f-bf67-9d38a255d13f
Amp-Thread-ID: https://ampcode.com/threads/T-019f1375-8955-726a-a8a4-52e501bb56db Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-019f1375-8955-726a-a8a4-52e501bb56db Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-019f1375-8955-726a-a8a4-52e501bb56db Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-019f1375-8955-726a-a8a4-52e501bb56db Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-019f1375-8955-726a-a8a4-52e501bb56db Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-019f1375-8955-726a-a8a4-52e501bb56db Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-019f1375-8955-726a-a8a4-52e501bb56db Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-019f1375-8955-726a-a8a4-52e501bb56db Co-authored-by: Amp <amp@ampcode.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
mark-wiemer
marked this pull request as draft
July 22, 2026 14:27
mark-wiemer
commented
Jul 22, 2026
mark-wiemer
commented
Jul 22, 2026
mark-wiemer
commented
Jul 22, 2026
mark-wiemer
commented
Jul 22, 2026
mark-wiemer
commented
Jul 22, 2026
mark-wiemer
commented
Jul 22, 2026
mark-wiemer
commented
Jul 22, 2026
mark-wiemer
commented
Jul 22, 2026
mark-wiemer
marked this pull request as ready for review
July 22, 2026 15:31
mark-wiemer
marked this pull request as draft
July 22, 2026 15:33
Member
Author
|
(Converting back to draft while I handle some local AI-generated feedback) |
mark-wiemer
marked this pull request as ready for review
July 22, 2026 15:56
Member
Author
|
(It was all hallucinations) |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6164 +/- ##
==========================================
- Coverage 82.55% 81.90% -0.65%
==========================================
Files 64 64
Lines 4798 4864 +66
Branches 1074 1072 -2
==========================================
+ Hits 3961 3984 +23
- Misses 837 880 +43 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This was referenced Jul 23, 2026
JoshuaKGoldberg
approved these changes
Jul 23, 2026
JoshuaKGoldberg
left a comment
Member
There was a problem hiding this comment.
Swell! We've both worked on this and it looks very good to me. I'm still a little nervous about edge cases in the CLI, but:
- This area has a lot of test coverage, including some added points (IMO the coverage drop is inaccurate and misleading)
- It's a major version that's going into RC anyway, little oddities are expected (and always fixable after the fact)
Merging now. 🚀
3 tasks done
This was referenced Sep 18, 2026
4 of 5 tasks
2 of 3 tasks
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
status: accepting prsOverview
Replaces
yargscommand dispatching with Node.js-nativeutil.parseArgs. Marked as a breaking change out of an abundance of caution.Behavior Changes
--helpoutput is now generated by Mocha instead of yargs, so exact formatting, grouping, and wrapping may differ while preserving the same user-facing information.--version/-Vand--help/-hare handled before run preparation, so they print version/help output even when other options such as--requirepoint to modules that cannot be loaded.(Ref #6128 and #6163 for paperwork issues)