Skip to content

chore: remove references to now-unused util.inherits - #5766

Merged
JoshuaKGoldberg merged 2 commits into
mainfrom
fix-5025
Feb 28, 2026
Merged

JoshuaKGoldberg merged 2 commits into
mainfrom
fix-5025

Conversation

@mark-wiemer

@mark-wiemer mark-wiemer commented Feb 21, 2026 •

Copy link
Copy Markdown
Member

PR Checklist

Overview

A set of previous PRs linked to the backing issue removed all references to this old symbol. Now we can fully remove it to mark the work complete :)

@mark-wiemer mark-wiemer changed the title chore: remove now-unused utils.inherits chore: remove references to now-unused util.inherits Feb 21, 2026
@mark-wiemer mark-wiemer self-assigned this Feb 21, 2026
@codecov

codecov Bot commented Feb 21, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.78%. Comparing base (c3f32ce) to head (bb1543b).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5766      +/-   ##
==========================================
+ Coverage   88.74%   88.78%   +0.03%     
==========================================
  Files          66       66              
  Lines        4744     4742       -2     
  Branches      976      976              
==========================================
  Hits         4210     4210              
+ Misses        534      532       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mark-wiemer mark-wiemer added this to the v12.0.0 milestone Feb 21, 2026
@mark-wiemer
mark-wiemer marked this pull request as ready for review February 21, 2026 19:45
@mark-wiemer

Copy link
Copy Markdown
Member Author

Gonna slow down now and wait for @mochajs/maintenance-crew folks to come back online :)

@mark-wiemer
mark-wiemer requested a review from a team February 21, 2026 19:46
@mark-wiemer mark-wiemer added the status: needs review a maintainer should (re-)review this pull request label Feb 22, 2026

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thus closes out the old inherits saga!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: needs review a maintainer should (re-)review this pull request

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

🐛 Bug: remove util.inherits / convert to classes

2 participants