Skip to content

fix(deps): update dependency find-up to v8 - #5747

Merged
JoshuaKGoldberg merged 6 commits into
mainfrom
renovate/find-up-8.x
Sep 4, 2026
Merged

JoshuaKGoldberg merged 6 commits into
mainfrom
renovate/find-up-8.x

Conversation

@renovate

@renovate renovate Bot commented Feb 21, 2026 •

Copy link
Copy Markdown
Contributor

This PR contains the following updates:

Package Change Age Confidence
find-up ^5.0.0 → ^8.0.0 age confidence

Release Notes

sindresorhus/find-up (find-up)

v8.0.0

Compare Source

Breaking
Improvements
  • Add {type: 'both'} option to find files or directories 67f453c
  • Add findDown and findDownSync to search descendant directories 8e02916

v7.0.0

Compare Source

Breaking
Improvements
  • Accept URL for stopAt option ba19153

v6.3.0

Compare Source

v6.2.0

Compare Source

v6.1.0

Compare Source

v6.0.0

Compare Source

Breaking
  • Require Node.js 12.20 e93cfd2
  • This package is now pure ESM. Please read this.
  • Changed from a default export to named exports.
    • const findUp = require('find-up') => import {findUp} from 'find-up'
    • const findUpSync = require('find-up').sync => import {findUpSync} from 'find-up'
    • const findUpStop = require('find-up').stop => import {findUpStop} from 'find-up'
    • const pathExists = require('find-up').exists => import {pathExists} from 'find-up'
    • const pathExistsSync = require('find-up').sync.exists => import {pathExistsSync} from 'find-up'

Configuration

📅 Schedule: (UTC)

  • Branch creation
    • At any time (no schedule defined)
  • Automerge
    • At any time (no schedule defined)

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@mark-wiemer

Copy link
Copy Markdown
Member

@copilot fix issues in this PR. Use npm 10

@mark-wiemer
mark-wiemer marked this pull request as draft February 21, 2026 03:19

Copilot AI commented Feb 21, 2026

Copy link
Copy Markdown
Contributor

@mark-wiemer I've opened a new pull request, #5756, to work on those changes. Once the pull request is ready, I'll request review from you.

@renovate
renovate Bot force-pushed the renovate/find-up-8.x branch from c6e96fa to 0aff7d4 Compare March 5, 2026 14:00
@renovate
renovate Bot force-pushed the renovate/find-up-8.x branch from 0aff7d4 to 5697d0a Compare March 13, 2026 16:16
@renovate
renovate Bot force-pushed the renovate/find-up-8.x branch 2 times, most recently from 864e249 to f0d4260 Compare April 1, 2026 17:42
@renovate
renovate Bot force-pushed the renovate/find-up-8.x branch 2 times, most recently from c73ba88 to 267afab Compare April 15, 2026 04:53
@renovate
renovate Bot force-pushed the renovate/find-up-8.x branch 2 times, most recently from 249c947 to e8c7923 Compare April 29, 2026 11:41
@renovate
renovate Bot force-pushed the renovate/find-up-8.x branch 2 times, most recently from 504361d to 0f79fdb Compare May 18, 2026 10:37
@renovate
renovate Bot force-pushed the renovate/find-up-8.x branch from 0f79fdb to e787b8e Compare May 28, 2026 16:00
@renovate
renovate Bot force-pushed the renovate/find-up-8.x branch from e787b8e to 871f82c Compare June 11, 2026 14:09
@renovate
renovate Bot force-pushed the renovate/find-up-8.x branch from 871f82c to 7bf1d8a Compare June 20, 2026 01:50
@renovate
renovate Bot force-pushed the renovate/find-up-8.x branch from 7bf1d8a to cb65b2f Compare July 4, 2026 16:22
@JoshuaKGoldberg

Copy link
Copy Markdown
Member

Since we're so close to releasing v12, I think we should wait to merge this until v12 is stable. So this'd be v12.x.

@JoshuaKGoldberg JoshuaKGoldberg added this to the v12.x milestone Jul 4, 2026
@renovate

renovate Bot commented Jul 4, 2026

Copy link
Copy Markdown
Contributor Author

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@mark-wiemer mark-wiemer added the status: blocked Waiting for something else to be resolved label Jul 24, 2026
@mark-wiemer mark-wiemer added this to Mocha Sep 2, 2026
@JoshuaKGoldberg JoshuaKGoldberg removed the status: blocked Waiting for something else to be resolved label Sep 4, 2026
@JoshuaKGoldberg
JoshuaKGoldberg marked this pull request as ready for review September 4, 2026 14:23
@codecov

codecov Bot commented Sep 4, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.03%. Comparing base (15aa7d1) to head (09f32e9).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5747   +/-   ##
=======================================
  Coverage   82.03%   82.03%           
=======================================
  Files          64       64           
  Lines        4927     4927           
  Branches     1114     1114           
=======================================
  Hits         4042     4042           
  Misses        885      885           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JoshuaKGoldberg
JoshuaKGoldberg merged commit ee11d29 into main Sep 4, 2026
81 checks passed
@JoshuaKGoldberg
JoshuaKGoldberg deleted the renovate/find-up-8.x branch September 4, 2026 16:27
@github-project-automation github-project-automation Bot moved this to Done in Mocha Sep 4, 2026
Comment thread lib/cli/config.cjs
const path = require("node:path");
const debug = require("debug")("mocha:cli:config");
const findUp = require("find-up");
const { findUpSync } = require("find-up");

@danielhjacobs danielhjacobs Sep 15, 2026 •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

find-up 8 is ESM only and does import "unicorn-magic", so this CommonJS require cannot work

@danielhjacobs danielhjacobs Sep 15, 2026 •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread lib/cli/options.cjs
const mocharc = require("../mocharc.json");
const { loadConfig, findConfig } = require("./config.cjs");
const { sync } = require("find-up");
const { findUpSync } = require("find-up");

@danielhjacobs danielhjacobs Sep 15, 2026 •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has the same issue as #5747 (comment)

@github-actions

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants