Skip to content

fix: change Pending to properly extend Error - #5679

Merged
mark-wiemer merged 2 commits into
mochajs:mainfrom
JoshuaKGoldberg:pending-error
Feb 14, 2026
Merged

mark-wiemer merged 2 commits into
mochajs:mainfrom
JoshuaKGoldberg:pending-error

Conversation

@JoshuaKGoldberg

Copy link
Copy Markdown
Member

PR Checklist

Overview

Gives it a name property and renames it from Pending to PendingError to match common conventions around extending Error.

🤎

@codecov

codecov Bot commented Feb 3, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.40%. Comparing base (15fb31a) to head (94893d8).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5679      +/-   ##
==========================================
- Coverage   88.44%   88.40%   -0.04%     
==========================================
  Files          66       66              
  Lines        4794     4795       +1     
  Branches      978      978              
==========================================
- Hits         4240     4239       -1     
- Misses        554      556       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JoshuaKGoldberg
JoshuaKGoldberg marked this pull request as ready for review February 3, 2026 16:14
@JoshuaKGoldberg JoshuaKGoldberg added this to the v12.x milestone Feb 3, 2026
@JoshuaKGoldberg JoshuaKGoldberg moved this to In Progress in Mocha Feb 3, 2026

@mark-wiemer mark-wiemer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm OK without a test for this one because it's just so darn obvious :D

@mark-wiemer
mark-wiemer merged commit 158effd into mochajs:main Feb 14, 2026
78 of 79 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in Mocha Feb 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

🐛 Bug: Pending constructor does not inherit from the Error constructor

2 participants