Repository navigation
fix: change Pending to properly extend Error - #5679
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5679 +/- ##
==========================================
- Coverage 88.44% 88.40% -0.04%
==========================================
Files 66 66
Lines 4794 4795 +1
Branches 978 978
==========================================
- Hits 4240 4239 -1
- Misses 554 556 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mark-wiemer
approved these changes
Feb 14, 2026
mark-wiemer
left a comment
Member
There was a problem hiding this comment.
I'm OK without a test for this one because it's just so darn obvious :D
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
status: accepting prsOverview
Gives it a
nameproperty and renames it fromPendingtoPendingErrorto match common conventions around extendingError.🤎