[lennonnikolas]

PR Checklist

• Addresses an existing open issue: closes 📦 Package: Bump chokidar from 4 to 5 #5586
• That issue was marked as status: accepting prs
• Steps in CONTRIBUTING.md were taken

Overview

• Upgrade chokidar package from v4 to v5
• Update lib/cli/watch-run.js to lazy-load chokidar

closes: #5586

[mark-wiemer]

@lennonnikolas these package bumps are not as easy as they seem! Please do run the CI checks on a fork before opening one here, as we already have #5587. Most package bumps have a similar draft PR opened by @JoshuaKGoldberg that you should probably fork and validate first :) Thank you for the effort regardless!

Going to mark this one as a draft for now.

[lennonnikolas]

@lennonnikolas these package bumps are not as easy as they seem! Please do run the CI checks on a fork before opening one here, as we already have #5587. Most package bumps have a similar draft PR opened by @JoshuaKGoldberg that you should probably fork and validate first :) Thank you for the effort regardless!

Going to mark this one as a draft for now.

Ah oops I thought I had marked this as a draft when I created the PR earlier, my apologies! Moving a little too fast. I have been running CI tests and yeah there are some things to consider with the current workflows. Also, I found that there was already a PR open for this when I had created one.

[paulmillr]

Is ESM-only chokidar a big deal for mocha or is it ok? I see your workaround.

Also, this PR is important to be able to fix trusted publishers issue.

[mark-wiemer]

@paulmillr ESM-only shouldn't be an issue in itself. Mocha v12 (and the current main branch) only support versions of Node that allow require-ing ESM modules, so we don't expect blocking issues there. Feel free to open your own PR on this as the current one is a bit stale :)

[mark-wiemer]

@paulmillr see also the convo in the backing issue for details: #5586

[JoshuaKGoldberg]

Closing out as #5586 was closed by #5734. Thanks for taking a stab at this!