Make Mocha runnable in an iframe #555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For Konacha, we'd love to be able to run Mocha inside an iframe, and have the report rendered in the top-level frame. Here is an illustration: http://i.imgur.com/qD8em.png I actually have this working in my Konacha working copy, and it's really cool and useful, but it needs just a little help from Mocha's side to work. This commit makes two small changes: * Make the root element for the HTML reporter parameterizable. (The default is still #mocha.) * Do not repeat the current path in the ?grep URLs. It's redundant, and it messes up the path with an iframe setup like we're trying to do. There are no functional changes on Mocha's end.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Konacha, we'd love to be able to run Mocha inside an iframe, and
have the report rendered in the top-level frame. Here is an
illustration:
http://i.imgur.com/qD8em.png
I actually have this working in my Konacha working copy, and it's really
cool and useful, but it needs just a little help from Mocha's side to
work. This commit makes two small changes:
default is still #mocha.)
it messes up the path with an iframe setup like we're trying to do.
There are no functional changes on Mocha's end.
Please merge this? It'd be super-awesome!