Skip to content

chore: bump glob to version 13 - #5546

Merged
mark-wiemer merged 1 commit into
mochajs:mainfrom
valadaptive:new-glob
Nov 25, 2025
Merged

mark-wiemer merged 1 commit into
mochajs:mainfrom
valadaptive:new-glob

Conversation

@valadaptive

@valadaptive valadaptive commented Nov 24, 2025 •

Copy link
Copy Markdown
Contributor

PR Checklist

Overview

This PR bumps the glob package to v13. It's an alternative to #5545, which only bumps it to v11 (and hence this PR closes #5545).

The reason to prefer v13 is that it moves the glob CLI into a separate package, greatly reducing the number of dependencies:

image image

As it stands right now, Mocha is bringing in two different CLI libraries: yargs, which is what it actually uses for its CLI, and jackspeak, which is pulled in for the completely-unused glob CLI functionality.

I've checked the glob changelog, and the only non-CLI change between v10 and v13 is that it's dropped support for Node <20, which Mocha v12 will no longer support either.

Moving forward, it may still be worth it to switch to tinyglobby, but this is a good incremental reduction in dependencies.

@mark-wiemer mark-wiemer mentioned this pull request Nov 25, 2025
3 tasks done
@codecov

codecov Bot commented Nov 25, 2025 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.69%. Comparing base (f75d150) to head (a851520).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5546   +/-   ##
=======================================
  Coverage   93.69%   93.69%           
=======================================
  Files          57       57           
  Lines        4396     4396           
  Branches      849      849           
=======================================
  Hits         4119     4119           
  Misses        277      277           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mark-wiemer mark-wiemer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@mark-wiemer
mark-wiemer merged commit f4d4ad2 into mochajs:main Nov 25, 2025
81 checks passed
lennonnikolas pushed a commit to lennonnikolas/mocha that referenced this pull request Jan 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants