Repository navigation
chore: bump glob to version 13 - #5546
Merged
Merged
Conversation
Closed
3 tasks done
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5546 +/- ##
=======================================
Coverage 93.69% 93.69%
=======================================
Files 57 57
Lines 4396 4396
Branches 849 849
=======================================
Hits 4119 4119
Misses 277 277 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
3 tasks done
lennonnikolas
pushed a commit
to lennonnikolas/mocha
that referenced
this pull request
Jan 24, 2026
5 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
status: accepting prsOverview
This PR bumps the
globpackage to v13. It's an alternative to #5545, which only bumps it to v11 (and hence this PR closes #5545).The reason to prefer v13 is that it moves the glob CLI into a separate package, greatly reducing the number of dependencies:
As it stands right now, Mocha is bringing in two different CLI libraries: yargs, which is what it actually uses for its CLI, and jackspeak, which is pulled in for the completely-unused glob CLI functionality.
I've checked the glob changelog, and the only non-CLI change between v10 and v13 is that it's dropped support for Node <20, which Mocha v12 will no longer support either.
Moving forward, it may still be worth it to switch to tinyglobby, but this is a good incremental reduction in dependencies.