Skip to content

feat: allow FIFOs as test files - #5512

Merged
mark-wiemer merged 4 commits into
mochajs:mainfrom
alxndrsn:test-from-fifo
Nov 22, 2025
Merged

mark-wiemer merged 4 commits into
mochajs:mainfrom
alxndrsn:test-from-fifo

Conversation

@alxndrsn

@alxndrsn alxndrsn commented Oct 22, 2025 •

Copy link
Copy Markdown
Contributor

Closes #5511

PR Checklist

Overview

Support running tests from FIFOs.

@linux-foundation-easycla

linux-foundation-easycla Bot commented Oct 22, 2025 •

Copy link
Copy Markdown

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: mark-wiemer / name: Mark Wiemer (6121853)

@alxndrsn
alxndrsn marked this pull request as draft October 22, 2025 06:55
@alxndrsn
alxndrsn marked this pull request as ready for review October 22, 2025 10:38
@codecov

codecov Bot commented Oct 27, 2025 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.69%. Comparing base (d2c2d40) to head (6121853).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5512   +/-   ##
=======================================
  Coverage   93.69%   93.69%           
=======================================
  Files          57       57           
  Lines        4391     4391           
  Branches      850      850           
=======================================
  Hits         4114     4114           
  Misses        277      277           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mark-wiemer

Copy link
Copy Markdown
Member

Thanks @alxndrsn, looks like this is a new feature, not a fix? Or did this behavior exist before and was lost? Regardless, can you add a unit test to cover this scenario?

@mark-wiemer
mark-wiemer self-requested a review November 1, 2025 16:43

@mark-wiemer mark-wiemer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again, here's the remaining work in my view:

  • add test
  • sign CLA
  • resolve lint issues

@mark-wiemer mark-wiemer changed the title fix: allow FIFOs as test files feat: allow FIFOs as test files Nov 8, 2025
@mark-wiemer mark-wiemer added the status: waiting for author waiting on response from OP or other posters - more information needed label Nov 8, 2025
@mark-wiemer
mark-wiemer marked this pull request as draft November 8, 2025 22:12
@alxndrsn
alxndrsn marked this pull request as ready for review November 10, 2025 10:57
@alxndrsn

Copy link
Copy Markdown
Contributor Author

I don't understand the codecov report - if anything it implies coverage has gone up?

@alxndrsn

Copy link
Copy Markdown
Contributor Author
  • add test
  • sign CLA
  • resolve lint issues

@mark-wiemer mark-wiemer removed the status: waiting for author waiting on response from OP or other posters - more information needed label Nov 21, 2025
@mark-wiemer
mark-wiemer self-requested a review November 21, 2025 04:27

@mark-wiemer mark-wiemer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alxndrsn yes CLA is signed, sorry you're seeing weird bugs. I'll continue working with support to make sure you and others don't have issues like this.

You can ignore the codecov comments as well, those are new. I think it was originally commenting on a "version 2" or your PR that had slightly less coverage than some "version 1" of your PR. But now we're on "version 3+" where the coverage of your changes is back up again :) overall it looks good and we don't have hard rules for coverage at this point.

Test looks good, approved!

@mark-wiemer mark-wiemer self-assigned this Nov 21, 2025

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 nice!

@mark-wiemer
mark-wiemer merged commit ca4af43 into mochajs:main Nov 22, 2025
80 checks passed
lennonnikolas pushed a commit to lennonnikolas/mocha that referenced this pull request Jan 24, 2026
Co-authored-by: alxndrsn <alxndrsn>
Co-authored-by: Mark Wiemer <7833360+mark-wiemer@users.noreply.github.com>
@mark-wiemer

Copy link
Copy Markdown
Member

(FYI for anyone like me who keeps forgetting FIFO meaning in this context. They're also known as named pipes: https://en.wikipedia.org/wiki/Named_pipe)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🚀 Feature: execute tests from FIFOs

3 participants