Repository navigation
feat: allow FIFOs as test files - #5512
Conversation
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5512 +/- ##
=======================================
Coverage 93.69% 93.69%
=======================================
Files 57 57
Lines 4391 4391
Branches 850 850
=======================================
Hits 4114 4114
Misses 277 277 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thanks @alxndrsn, looks like this is a new feature, not a fix? Or did this behavior exist before and was lost? Regardless, can you add a unit test to cover this scenario? |
mark-wiemer
left a comment
There was a problem hiding this comment.
Thanks again, here's the remaining work in my view:
- add test
- sign CLA
- resolve lint issues
|
mark-wiemer
left a comment
There was a problem hiding this comment.
@alxndrsn yes CLA is signed, sorry you're seeing weird bugs. I'll continue working with support to make sure you and others don't have issues like this.
You can ignore the codecov comments as well, those are new. I think it was originally commenting on a "version 2" or your PR that had slightly less coverage than some "version 1" of your PR. But now we're on "version 3+" where the coverage of your changes is back up again :) overall it looks good and we don't have hard rules for coverage at this point.
Test looks good, approved!
Co-authored-by: alxndrsn <alxndrsn> Co-authored-by: Mark Wiemer <7833360+mark-wiemer@users.noreply.github.com>
|
(FYI for anyone like me who keeps forgetting FIFO meaning in this context. They're also known as named pipes: https://en.wikipedia.org/wiki/Named_pipe) |

Closes #5511
PR Checklist
status: accepting prsOverview
Support running tests from FIFOs.