[JoshuaKGoldberg]

PR Checklist

• Addresses an existing open issue: fixes 📦 Package: Bump strip-json-comments from 3 to 5 #5334
• That issue was marked as status: accepting prs
• Steps in CONTRIBUTING.md were taken

Overview

Bumps the package from ^3.1.1 to ^5.0.3.

Similar to #5482, this increases the lockfile size for local development dependencies. This is because strip-json-comments@3 is still referenced by:

$ npm ls strip-json-comments@3
mocha@11.7.4 /Users/josh/repos/mocha
├─┬ eslint@8.56.0
│ └─┬ @eslint/eslintrc@2.1.4
│   └── strip-json-comments@3.1.1
├─┬ jsdoc@3.6.11
│ └── strip-json-comments@3.1.1
└─┬ markdownlint-cli@0.30.0
  └─┬ run-con@1.2.11
    └── strip-json-comments@3.1.1

• eslint is tracked in 🛠 Repo: Bump eslint from 8 to 9 #5483
• jsdoc is tracked in 🛠️ Repo: Bump jsdoc from 3 to 4 #5485
• markdownlint-cli is tracked in 🛠 Repo: Bump markdownlint-cli from 0.30 to 0.45 #5486

💖

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.52%. Comparing base (410ce0d) to head (ac5c16f).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #5484   +/-   ##
=======================================
  Coverage   93.52%   93.52%           
=======================================
  Files          57       57           
  Lines        4465     4465           
  Branches      918      918           
=======================================
  Hits         4176     4176           
  Misses        289      289           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[MrChocolatine]

How come these dependency updates are marked as "feature"?

[JoshuaKGoldberg]

Because they change and improve the code that runs at runtime. Mocha is so widely used that even subtle changes to thinks like dependencies have broken end-users in the past. Just to be safe, we've been putting these as features.

[MrChocolatine]

Because they change and improve the code that runs at runtime. Mocha is so widely used that even subtle changes to thinks like dependencies have broken end-users in the past. Just to be safe, we've been putting these as features.

Thanks for the explanation @JoshuaKGoldberg .