Repository navigation
chore: use ps-list instead of pidtree to remove wmic - #5479
Merged
Merged
Conversation
JoshuaKGoldberg
removed
the
status: blocked
JoshuaKGoldberg
approved these changes
Oct 2, 2025
Member
There was a problem hiding this comment.
[Praise] 👌 very clean in this file, nice!
| "needle": "^2.5.0", | ||
| "npm-run-all2": "^6.2.0", | ||
| "nyc": "^15.1.0", | ||
| "pidtree": "^0.5.0", |
Member
There was a problem hiding this comment.
[Non-Actionable] It is kind of funny to me that pidtree's README.md mentions it exists because a previous project is unmaintained. And pidtree itself is now unmaintained, last commit 3 years ago.
Member
Author
There was a problem hiding this comment.
the circle of life :)
5 tasks done
lennonnikolas
pushed a commit
to lennonnikolas/mocha
that referenced
this pull request
Jan 24, 2026
Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
test-node:integrationon windows-latest for--paralleltests #5467status: accepting prsOverview
pidtreerelies onwmic, an outdated Windows utility which is no longer included in the latest versions of Windows Server. GitHub Actions uses Windows Server, so any test usingwmicfails, including our 2 tests that usepidtree. We are able to switch to a more modernps-list(no new deps in package-lock) to fix this.Took this opportunity to simplify the tests as well: They now expect a list of
falses indicating the processes don't exist. Although this may harm debuggability, these tests haven't failed in years and readability feels more important for future maintenance work.ps-list requires Node 20+, so this is blocked on #5477