Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix header generation and production build crashes #5100

Merged
merged 6 commits into from
Feb 27, 2024
Merged

chore: fix header generation and production build crashes #5100

merged 6 commits into from
Feb 27, 2024

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg commented Feb 24, 2024 •
edited
Loading

PR Checklist

Overview

Three fixes:

  • Uses the direct node path as suggested in 📝 Docs: Nightly Netlify deploys are failing #5098 (comment)
  • Removes the crashing scripts/netlify-headers.js. Which IMO is not necessary given how well Netlify performs by default. 🔪
  • Removes the RUBY_VERSION env variable and bumps NODE_VERSION to 20 Nope, that caused a crash

@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as draft February 24, 2024 22:42
@JoshuaKGoldberg JoshuaKGoldberg changed the title chore: use direct path to assetgraph-builder > buildProduction in nps chore: correct assetgraph-builder > buildProduction script, and remove scripts/netlify-headers.js Feb 24, 2024
@JoshuaKGoldberg JoshuaKGoldberg changed the title chore: correct assetgraph-builder > buildProduction script, and remove scripts/netlify-headers.js chore: fix header generation and production build crashes Feb 24, 2024
@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review February 24, 2024 23:14
@voxpelli voxpelli merged commit 51502ab into mochajs:master Feb 27, 2024
26 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the node-bin-build-production branch February 27, 2024 16:11
@M0ng00se7169 M0ng00se7169 mentioned this pull request May 21, 2024
Merged
@WontonSam WontonSam mentioned this pull request Jun 8, 2024
Open
@matrix-compute matrix-compute mentioned this pull request Jun 24, 2024
Open
This was referenced Jul 16, 2024
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Nov 1, 2024
Open
Open
Open
Open
@HaLaGu1L HaLaGu1L mentioned this pull request Nov 1, 2024
Open
This was referenced Nov 1, 2024
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Nov 9, 2024
Open
Open
@SkyeFull90 SkyeFull90 mentioned this pull request Nov 9, 2024
Merged
This was referenced Nov 9, 2024
Open
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@voxpelli voxpelli voxpelli approved these changes

@Uzlopak Uzlopak Awaiting requested review from Uzlopak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

📝 Docs: Nightly Netlify deploys are failing
2 participants
@JoshuaKGoldberg @voxpelli