chore: revert #5069 to restore Netlify builds #5095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`assetgraph-builder` is used through at least the `buildProduction` command This reverts commit 53a4baf.
voxpelli
added
type: bug
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Compliance Checks
Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.
Issue Reference
In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our Contributing Guide. We are closing this pull request for now but you can update the pull request description and reopen the pull request.
The check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.
JoshuaKGoldberg
requested changes
Feb 15, 2024
JoshuaKGoldberg
approved these changes
Feb 15, 2024
JoshuaKGoldberg
requested changes
Feb 15, 2024
|
😄 we can always come back to this |
3 tasks
5 tasks
3 tasks
This was referenced Jul 16, 2024
This was referenced Nov 1, 2024
This was referenced Nov 1, 2024
This was referenced Nov 9, 2024
This was referenced Nov 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
assetgraph-builderis used through at least thebuildProductioncommandThis reverts commit 53a4baf.
PR Checklist
Addresses an existing open issue: fixes #000That issue was marked asstatus: accepting prsOverview
Reverts #5069 to restore Netlify builds by adding back
assetgraph-builderDownside: Installs on non-x86 machines again require
--ignore-scripts: #4828 (comment)