Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: revert #5069 to restore Netlify builds #5095

Merged
merged 1 commit into from
Feb 15, 2024
Merged

Conversation

voxpelli
Copy link
Member

@voxpelli voxpelli commented Feb 15, 2024

assetgraph-builder is used through at least the buildProduction command

This reverts commit 53a4baf.

PR Checklist

Overview

Reverts #5069 to restore Netlify builds by adding back assetgraph-builder

Downside: Installs on non-x86 machines again require --ignore-scripts: #4828 (comment)

`assetgraph-builder` is used through at least the `buildProduction` command

This reverts commit 53a4baf.
@voxpelli voxpelli added type: bug a defect, confirmed by a maintainer area: website involving mochajs.org, but not necessarily involving docs labels Feb 15, 2024
@voxpelli voxpelli self-assigned this Feb 15, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Issue Reference

In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our Contributing Guide. We are closing this pull request for now but you can update the pull request description and reopen the pull request.
The check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.

@coveralls
Copy link

Coverage Status

coverage: 94.335%. remained the same
when pulling 471e25d on fix-betlify-build
into 8317f90 on master.

Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can keep the removal of canvas? Otherwise LGTM (alas)

package.json Show resolved Hide resolved
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or, actually, wait - docs/* doesn't need to be reverted. It doesn't need to use canvas.

@voxpelli voxpelli merged commit 3345eff into master Feb 15, 2024
52 of 56 checks passed
@voxpelli voxpelli deleted the fix-betlify-build branch February 15, 2024 13:49
@JoshuaKGoldberg
Copy link
Member

😄 we can always come back to this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: website involving mochajs.org, but not necessarily involving docs type: bug a defect, confirmed by a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants