-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: revert #5069 to restore Netlify builds #5095
Conversation
`assetgraph-builder` is used through at least the `buildProduction` command This reverts commit 53a4baf.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Compliance Checks
Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.
Issue Reference
In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our Contributing Guide. We are closing this pull request for now but you can update the pull request description and reopen the pull request.
The check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can keep the removal of canvas
? Otherwise LGTM (alas)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or, actually, wait - docs/*
doesn't need to be reverted. It doesn't need to use canvas
.
😄 we can always come back to this |
assetgraph-builder
is used through at least thebuildProduction
commandThis reverts commit 53a4baf.
PR Checklist
Addresses an existing open issue: fixes #000That issue was marked asstatus: accepting prs
Overview
Reverts #5069 to restore Netlify builds by adding back
assetgraph-builder
Downside: Installs on non-x86 machines again require
--ignore-scripts
: #4828 (comment)