Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update chokidar to 3.6.0 #5090

Closed
wants to merge 1 commit into from
Closed

Conversation

orgads
Copy link
Contributor

@orgads orgads commented Feb 8, 2024

Overview

Update chokidar to 3.6.0.

Copy link

linux-foundation-easycla bot commented Feb 8, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: orgads / name: Orgad Shaneh (2456392)

@voxpelli
Copy link
Member

@orgads There are lots of outdated dependencies in this project, to help us prioritize, can you explain the reasoning for updating this specific one?

@orgads
Copy link
Contributor Author

orgads commented Feb 16, 2024

nest-cli updated to 3.6.0 (pinned), and it uses mocha.

Is there a reason you use a pinned version and not any matching minor version (^)?

@JoshuaKGoldberg
Copy link
Member

I think the not using ^ versions is the more curious point to investigate. Filed #5114.

Marking this one as draft pending discussion there.

Thanks for pointing this out!

@JoshuaKGoldberg JoshuaKGoldberg added the status: blocked Waiting for something else to be resolved label Mar 4, 2024
@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as draft March 4, 2024 18:59
@voxpelli
Copy link
Member

nest-cli updated to 3.6.0 (pinned), and it uses mocha.

@orgads And the benefit of updating here is that the chokidar in nest-cli and in mocha can be deduped by npm and thus you get fewer individual versions in your node_modules?

Or any more urgent issue?

@orgads
Copy link
Contributor Author

orgads commented Mar 12, 2024

It's been a month 😅

IIRC there was a Typescript compatibility issue too, but I'm unsure.

@voxpelli
Copy link
Member

All dependencies will be updated in due time as we move further in our reboot of the project (#5027) and eventually be done so with automated PR:s: #5055

But if any dependency is causing urgent issues then it of course requires more urgent attention, hence my questions 🙂

@voxpelli voxpelli mentioned this pull request Sep 16, 2024
3 tasks
@voxpelli
Copy link
Member

Closing, we will update dependencies together with Mocha 11, #5216, no need for separate PR:s.

@voxpelli voxpelli closed this Sep 16, 2024
@orgads orgads deleted the chokidar-up branch September 16, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: blocked Waiting for something else to be resolved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants