Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add mtfoley/pr-compliance-action #5077

Merged

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg commented Jan 15, 2024

PR Checklist

Overview

Brings in https://github.com/mtfoley/pr-compliance-action with two customizations to the default settings:

  • body-auto-close: false: to be a bit more gentle to PRs
  • ignore-team-members: false: in case we typo, we should be caught too

@JoshuaKGoldberg JoshuaKGoldberg requested a review from a team January 15, 2024 04:24
@coveralls
Copy link

coveralls commented Jan 15, 2024

Coverage Status

coverage: 94.335%. remained the same
when pulling aa6815e on JoshuaKGoldberg:pr-compliance-action
into 53a4baf on mochajs:master.

Copy link
Member

@voxpelli voxpelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets try it out!

@voxpelli
Copy link
Member

voxpelli commented Feb 5, 2024

How will this handle existing PR:s by the way? Probably shouldn't merge if it causes retroactive comments 🙈

@JoshuaKGoldberg
Copy link
Member Author

It'll only comment when they're edited. I've been trying to get through the last of the issues and then reviewing PRs. Let's merge it when all PRs have been adjusted, then?

@voxpelli
Copy link
Member

voxpelli commented Feb 5, 2024

If it's only when they are edited that feels fine as well

Copy link
Member

@Uzlopak Uzlopak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am also pro testing. I dont know what to expect but hope it is not too nagging and encouraging positively conformity.

@JoshuaKGoldberg
Copy link
Member Author

Scene from the old Ten Commandments movie where two Egyptian royals are talking. Caption: "so it shall be done"

@JoshuaKGoldberg JoshuaKGoldberg merged commit f9e87d6 into mochajs:master Feb 8, 2024
24 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the pr-compliance-action branch February 8, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🛠 Repo: Add PR compliance action
4 participants