-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add mtfoley/pr-compliance-action #5077
chore: add mtfoley/pr-compliance-action #5077
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets try it out!
How will this handle existing PR:s by the way? Probably shouldn't merge if it causes retroactive comments 🙈 |
It'll only comment when they're edited. I've been trying to get through the last of the issues and then reviewing PRs. Let's merge it when all PRs have been adjusted, then? |
If it's only when they are edited that feels fine as well |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am also pro testing. I dont know what to expect but hope it is not too nagging and encouraging positively conformity.
PR Checklist
status: accepting prs
Overview
Brings in https://github.com/mtfoley/pr-compliance-action with two customizations to the default settings:
body-auto-close: false
: to be a bit more gentle to PRsignore-team-members: false
: in case we typo, we should be caught too