-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
uncaughtException: report more than one exception per test #4033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juergba
force-pushed
the
juergba/uncaught-double
branch
2 times, most recently
from
October 2, 2019 14:46
e5cdb72
to
a67c118
Compare
juergba
added
area: async
related to asynchronous use of Mocha
type: bug
a defect, confirmed by a maintainer
status: needs review
a maintainer should (re-)review this pull request
semver-patch
implementation requires increase of "patch" version number; "bug fixes"
labels
Oct 2, 2019
juergba
force-pushed
the
juergba/uncaught-double
branch
from
October 8, 2019 14:50
a67c118
to
ff7b5bb
Compare
I'm going to merge this PR within the next few days. |
craigtaub
approved these changes
Oct 12, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
juergba
force-pushed
the
juergba/uncaught-double
branch
from
October 13, 2019 08:24
ff7b5bb
to
4f247da
Compare
juergba
force-pushed
the
juergba/uncaught-double
branch
from
October 13, 2019 08:53
4f247da
to
7e2782e
Compare
juergba
removed
the
status: needs review
a maintainer should (re-)review this pull request
label
Oct 13, 2019
boneskull
pushed a commit
that referenced
this pull request
Oct 18, 2019
This was referenced Oct 27, 2019
This was referenced May 21, 2024
This was referenced Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: async
related to asynchronous use of Mocha
landed-on-v6.2.x
cherry-picked on v6.2.x branch from master
semver-patch
implementation requires increase of "patch" version number; "bug fixes"
type: bug
a defect, confirmed by a maintainer
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The first error is not reported at all, instead the output shows two copies of the second error.
Description of the Change
test.err
: currently is storing just one error per test, in case of multiple errors it's the last one. I haven't changed its type toArray
for backwards compability and instead introduced a new propertytest.err.multiple
to store additional errors. The latter is set within theEVENT_TEST_FAIL
event handler.Base.list()
which is part of the epilogue used by most builtin reporters.Base#epilogue()
remain mostly unchanged and do not list multiple errors per test. They list now the first error instead of the last one.Applicable issues
#2906 partially