-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test for Runner event order #3642
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,59 @@ | ||
'use strict'; | ||
|
||
var helpers = require('./helpers'); | ||
var runMochaJSON = helpers.runMochaJSON; | ||
|
||
describe('event order', function() { | ||
describe('trivial test case', function() { | ||
it('should assert trivial event order', function(done) { | ||
runMochaJSON('runner/events-basic.fixture.js', [], function(err, res) { | ||
if (err) { | ||
done(err); | ||
return; | ||
} | ||
expect(res, 'to have passed') | ||
.and('to have passed test count', 2) | ||
.and('to have passed test order', 'test A', 'test B') | ||
.and('to have failed test count', 0); | ||
done(); | ||
}); | ||
}); | ||
}); | ||
|
||
describe('--bail test case', function() { | ||
it('should assert --bail event order', function(done) { | ||
runMochaJSON('runner/events-bail.fixture.js', ['--bail'], function( | ||
err, | ||
res | ||
) { | ||
if (err) { | ||
done(err); | ||
return; | ||
} | ||
expect(res, 'to have failed with error', 'error test A') | ||
.and('to have failed test count', 1) | ||
.and('to have passed test count', 0); | ||
done(); | ||
}); | ||
}); | ||
}); | ||
|
||
describe('--retries test case', function() { | ||
it('should assert --retries event order', function(done) { | ||
runMochaJSON( | ||
'runner/events-retries.fixture.js', | ||
['--retries', '1'], | ||
function(err, res) { | ||
if (err) { | ||
done(err); | ||
return; | ||
} | ||
expect(res, 'to have failed with error', 'error test A') | ||
.and('to have failed test count', 1) | ||
.and('to have passed test count', 0); | ||
done(); | ||
} | ||
); | ||
}); | ||
}); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
'use strict'; | ||
var Runner = require('../../../../lib/runner.js'); | ||
var assert = require('assert'); | ||
|
||
var emitOrder = [ | ||
'suite'/* incorrect order*/, 'start', 'suite', | ||
'hook', 'hook end', 'test', 'hook', 'hook end', 'fail', 'test end', 'hook', 'hook end', | ||
'hook', 'hook end', 'suite end', 'suite end', 'end' | ||
]; | ||
|
||
var realEmit = Runner.prototype.emit; | ||
Runner.prototype.emit = function(event, ...args) { | ||
// console.log(`emit: ${event}`); | ||
assert.strictEqual(event, emitOrder.shift()); | ||
return realEmit.call(this, event, ...args); | ||
}; | ||
|
||
describe('suite A', function() { | ||
before('before', function() {}); | ||
beforeEach('beforeEach', function() {}); | ||
it('test A', function() { | ||
throw new Error('error test A'); | ||
}); | ||
describe('suite B', function() { | ||
it('test B', function() {}); | ||
}); | ||
afterEach('afterEach', function() {}); | ||
after('after', function() {}); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
'use strict'; | ||
var Runner = require('../../../../lib/runner.js'); | ||
var assert = require('assert'); | ||
|
||
var emitOrder = [ | ||
'suite'/* incorrect order*/, 'start', 'suite', | ||
'hook', 'hook end', 'test', 'hook', 'hook end', 'pass', 'test end', 'hook', 'hook end', | ||
'suite', 'test', 'hook', 'hook end', 'pass', 'test end', 'hook', 'hook end', | ||
'suite end', 'hook', 'hook end', 'suite end', 'suite end', 'end' | ||
]; | ||
|
||
var realEmit = Runner.prototype.emit; | ||
Runner.prototype.emit = function(event, ...args) { | ||
// console.log(`emit: ${event}`); | ||
assert.strictEqual(event, emitOrder.shift()); | ||
return realEmit.call(this, event, ...args); | ||
}; | ||
|
||
describe('suite A', function() { | ||
before('before', function() {}); | ||
beforeEach('beforeEach', function() {}); | ||
it('test A', function() {}); | ||
describe('suite B', function() { | ||
it('test B', function() {}); | ||
}); | ||
afterEach('afterEach', function() {}); | ||
after('after', function() {}); | ||
}); |
27 changes: 27 additions & 0 deletions
27
test/integration/fixtures/runner/events-retries.fixture.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
'use strict'; | ||
var Runner = require('../../../../lib/runner.js'); | ||
var assert = require('assert'); | ||
|
||
var emitOrder = [ | ||
'suite'/* incorrect order*/, 'start', 'suite', | ||
'hook', 'hook end', 'test', 'hook', 'hook end', 'retry', 'hook', 'hook end', | ||
'test', 'hook', 'hook end', 'fail', 'test end', 'hook', 'hook end', 'hook', 'hook end', | ||
'suite end', 'suite end', 'end' | ||
]; | ||
|
||
var realEmit = Runner.prototype.emit; | ||
Runner.prototype.emit = function(event, ...args) { | ||
// console.log(`emit: ${event}`); | ||
assert.strictEqual(event, emitOrder.shift()); | ||
return realEmit.call(this, event, ...args); | ||
}; | ||
|
||
describe('suite A', function() { | ||
before('before', function() {}); | ||
beforeEach('beforeEach', function() {}); | ||
it('test A', function() { | ||
throw new Error('error test A'); | ||
}); | ||
afterEach('afterEach', function() {}); | ||
after('after', function() {}); | ||
}); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This order changes when 00ca06b is removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, see #3414 which shows event order before and after merging 00ca06b.