Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent timeout value from skirting limit check #3536

Merged
merged 8 commits into from
Nov 9, 2018
Merged

Prevent timeout value from skirting limit check #3536

merged 8 commits into from
Nov 9, 2018

Commits on Oct 27, 2018

  1. fix(runnable.js): Prevent timeout value from skirting limit check 

    Moved the timestring->value translation code to before the limit check. Updated the function
documentation.
    @plroebuck
    plroebuck committed Oct 27, 2018
    Configuration menu
    Copy the full SHA
    64764f5 View commit details
    Browse the repository at this point in the history

  2. fix(runnable.js): Something screwed up the function documentation 

    Put it back as originally typed
    @plroebuck
    plroebuck committed Oct 27, 2018
    Configuration menu
    Copy the full SHA
    2fac117 View commit details
    Browse the repository at this point in the history

  3. docs(runnable.js): FU prettier 

    Prettier keeps rewriting my documentation **wrong**.
    @plroebuck
    plroebuck committed Oct 27, 2018
    Configuration menu
    Copy the full SHA
    96f5c18 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2018

  1. fix(lib/runnable.js): Fix timeout upper limit check (again) 

    Seems PR mochajs#1652 upper limit check was off by one. Fixed it and documentation.
    @plroebuck
    plroebuck committed Nov 6, 2018
    Configuration menu
    Copy the full SHA
    72f60d9 View commit details
    Browse the repository at this point in the history

  2. test(unit/runnable.spec.js): Updated tests for #timeout(ms) 

    Restructured tests for normal, eq upper, exceeds upper limit checks given both numeric and timestamp
input. No checking against lower limit.
    @plroebuck
    plroebuck committed Nov 6, 2018
    Configuration menu
    Copy the full SHA
    5d4ac5f View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2018

  1. feat(lib/utils.js): Add clamp function 

    Added function which clamps a numeric value to a range.
    @plroebuck
    plroebuck committed Nov 9, 2018
    Configuration menu
    Copy the full SHA
    20083cb View commit details
    Browse the repository at this point in the history

  2. fix(lib/runnable.js): Fix timeout range issue for good 

    Found that previous "fix" hadn't actually fixed the correct value, as the wrong upper bound value
had been used. Further checks indicated that IE had problems (surprise, surprise) with negative
timeout values. New code clamps to nonnegative range ending at `INT_MAX`.

Closes mochajs#1652
    @plroebuck
    plroebuck committed Nov 9, 2018
    Configuration menu
    Copy the full SHA
    0a88350 View commit details
    Browse the repository at this point in the history

  3. test(unit/runnable.spec.js): Update timeout tests to verify upper and… 

    … lower bounds
    @plroebuck
    plroebuck committed Nov 9, 2018
    Configuration menu
    Copy the full SHA
    0685cdc View commit details
    Browse the repository at this point in the history